Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't perform a merge query when report type is metadata only #4886

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

thorfour
Copy link
Contributor

It appears that if the report type was of type QueryRequest_REPORT_TYPE_PROFILE_METADATA that we would still perform a merge query, throw away the samples, and then perform the metadata query.

I believe we can just perform the metadata query and not perform the merge query.

Copy link

alwaysmeticulous bot commented Jul 23, 2024

✅ Meticulous spotted zero visual differences across 494 screens tested: view results.

Expected differences? Click here. Last updated for commit d5b1813. This comment will update as new commits are pushed.

@thorfour thorfour force-pushed the dont-perform-unecessary-queries branch from 432383f to d5b1813 Compare July 24, 2024 13:00
@thorfour thorfour enabled auto-merge (squash) July 24, 2024 13:00
@thorfour thorfour merged commit f887be9 into main Jul 24, 2024
35 checks passed
@thorfour thorfour deleted the dont-perform-unecessary-queries branch July 24, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants