Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add source report: View sources and show profiling data inline #3666

Merged
merged 14 commits into from
Aug 23, 2023

Conversation

brancz
Copy link
Member

@brancz brancz commented Aug 23, 2023

This is a very exciting moment where a lot of things are coming together. This allows using uploaded source code to be viewed inline with profiling data:

Screenshot 2023-08-23 at 12 37 07

For me personally, this was the only feature I ever still opened the pprof toolchain for, and this is even better than that since it always matches code correctly based on the build ID.

@brancz brancz requested review from a team as code owners August 23, 2023 10:39
@alwaysmeticulous
Copy link

alwaysmeticulous bot commented Aug 23, 2023

🤖 Meticulous spotted visual differences in 30 of 246 screens tested: view and approve differences detected.

Last updated for commit 6d30b6a. This comment will update as new commits are pushed.

@brancz brancz deleted the read-sources branch August 23, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants