pkg/query: Improve flamegraph performance through dictionary unification #3651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Meticulous spotted visual differences in 26 of 171 screens tested: view and approve differences detected. Last updated for commit b8255ee. This comment will update as new commits are pushed. |
brancz
force-pushed
the
arrow-dict-unifier
branch
from
b13fa21 to
64e9ecb
Compare
brancz
force-pushed
the
arrow-dict-unifier
branch
from
86dba7e to
a307896
Compare
Previously we looked at each individual string to be inserted into the resulting flamegraph, which was very inefficient since strings occur many times over. That causes dictionary building to be inefficient, but also comparisons are done on strings rather than integers. Changing this to use dictionary unification and transposing yielded a very good performance improvement: ``` $ benchstat old.txt new.txt name old time/op new time/op delta ArrowFlamegraph-10 5.95ms ± 0% 3.38ms ± 0% -43.28% (p=0.008 n=5+5) ```
brancz
force-pushed
the
arrow-dict-unifier
branch
from
3100faf to
092f970
Compare
|
The latest commit (removing maps from tracking labels) improves it by another 15%: |
brancz
force-pushed
the
arrow-dict-unifier
branch
from
092f970 to
d38b713
Compare
asubiotto
approved these changes
Aug 21, 2023
asubiotto
reviewed
Aug 21, 2023
pkg/query/flamegraph_arrow.go
Outdated
| @@ -270,9 +281,106 @@ func generateFlamegraphArrowRecord(ctx context.Context, mem memory.Allocator, tr | |||
| return record, fb.cumulative, fb.maxHeight + 1, 0, nil | |||
| } | |||
|
|
|||
| type transpositions struct { | |||
| mappingIDIndicesData *array.Data | |||
There was a problem hiding this comment.
nit: I think it would be nicer to unify these *Data and *Indices fields into a struct to halve the number of fields here and e.g. Release calls.
There was a problem hiding this comment.
as in encapsulate them in a struct, or how do you mean?
metalmatze
reviewed
Aug 21, 2023
pkg/query/flamegraph_arrow.go
Outdated
Comment on lines
839
to
844
| if r.Mapping.IsValid(locationRow) { | ||
| fb.builderMappingStart.Append(r.MappingStart.Value(locationRow)) | ||
| fb.builderMappingLimit.Append(r.MappingLimit.Value(locationRow)) | ||
| fb.builderMappingOffset.Append(r.MappingOffset.Value(locationRow)) | ||
| fb.builderMappingFileIndices.Append(t.mappingFileIndices.Value(r.MappingFile.GetValueIndex(locationRow))) | ||
| fb.builderMappingBuildIDIndices.Append(t.mappingIDIndices.Value(r.MappingBuildID.GetValueIndex(locationRow))) |
| @@ -26,16 +32,20 @@ export function nodeLabel( | |||
| showBinaryName: boolean | |||
| ): string { | |||
| const functionName: string | null = table.getChild(FIELD_FUNCTION_NAME)?.get(row); | |||
| const labelsOnly: boolean | null = table.getChild(FIELD_LABELS_ONLY)?.get(row); | |||
| const labels: string | null = table.getChild(FIELD_LABELS)?.get(row); | |||
| console.log(labelsOnly, labels); | |||
There was a problem hiding this comment.
We probably want to remove this before merging.
| return functionName; | ||
| } | ||
|
|
||
| if (level === 1 && labelsOnly !== null && labelsOnly && labels !== null && labels !== '') { |
There was a problem hiding this comment.
If we now have this labelsOnly column to read from, we can probably remove passing the level all the way down.
brancz
force-pushed
the
arrow-dict-unifier
branch
from
79365ec to
27c19e1
Compare
brancz
force-pushed
the
arrow-dict-unifier
branch
from
bb10c79 to
b8255ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we looked at each individual string to be inserted into the resulting flamegraph, which was very inefficient since strings occur many times over. That causes dictionary building to be inefficient, but also comparisons are done on strings rather than integers.
Changing this to use dictionary unification and transposing yielded a very good performance improvement: