flamegraph_arrow: Inject artifical label node #3516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Meticulous replayed 50 user sessions and took 214 screenshots. Meticulous has not yet run on 77528a2 of the main branch and so there was nothing to compare against. If you recently setup Meticulous, this is expected. Meticulous will start reporting comparisons for new pull requests after the next commit to the main branch. Last updated for commit f4ff76b. This comment will update as new commits are pushed. |
metalmatze
force-pushed
the
flamegraph-arrow-labels-grouping
branch
from
fc73962 to
b31af79
Compare
brancz
reviewed
Aug 8, 2023
| // Add this label row to the root row's children. | ||
| fb.children[0] = append(fb.children[0], row) | ||
| //// Add the next row as child of this label row. | ||
| //fb.children[row] = append(fb.children[row], row+1) |
There was a problem hiding this comment.
I don't think this has been resolved?
brancz
approved these changes
Aug 9, 2023
When grouping by pprof labels we want to inject a node beneath the root into the flamegraph that contains the name of that label. This will make finding the correct stacks by pprof labels easier.
Instead of showing ``{"thread_name":"foo"}` we're going to parse the JSON and display it as `thread_name="foo"` in a Prometheus fashion.
metalmatze
force-pushed
the
flamegraph-arrow-labels-grouping
branch
from
df84982 to
f4ff76b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the backend, we check every sample for its pprof labels.
If it has pprof labels we either inject a artifical node into the stack containing the pprof labels as JSON for the function name, or we merge the stack into the already existing same pprof label node.
In the frontend, instead of showing
{"thread_name":"foo"}we're going to parse the JSON and display it asthread_name="foo"in a Prometheus fashion. Given that each injected pprof label node is unique the drilling down into the icicle graph by function name now works flawlessly again. 👍