ui: Redundant query request fix #3331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Works perfectly now! Thanks for taking care of this! Looks like some lint is failing otherwise lgtm |
yomete
reviewed
Jun 21, 2023
| @@ -15,7 +15,7 @@ | |||
| * Divides two bigints and returns a number with two decimal places | |||
| */ | |||
| export const divide = (a: bigint, b: bigint): number => { | |||
| return Number((a * 10000n) / b) / 10000; | |||
| return Number((a * 1000000n) / b) / 1000000; | |||
There was a problem hiding this comment.
out of curiosity, why did the value being multiplied by change here?
There was a problem hiding this comment.
Since bigint divisions don't give any decimals, we premultiply it by 1M and then divide the result again by 1M to get the result with decimals.
I increased the number from 10K to 1M to get more precision to the decimal part, which was needed for the linearScale function.
Hope it answers the question.
yomete
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains the following:
nodeThreshold.@parca/hookspackage version drift from the the consumed version.linearScalescale function.Resolves #2823