ui: DateTimePicker adds seconds and uses yyyy-MM-dd HH:mm:ss #2920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both Prometheus and Grafana use the above format for absolute formatting. Personally, I think that makes a lot of sense especially when using UTC all over the place. Given we also have #2024 too, I went ahead and made the change in the DateTimePicker already and not only adding seconds. Additionally, I fixed some styling issues along the way. Most prominently, the `p-2` to `pt-4` which had the DateTimeRangePicker offset horizontally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both Prometheus and Grafana use the above format for absolute formatting. Personally, I think that makes a lot of sense, especially when using UTC all over the place. Given we also have #2024 too, I went ahead and made the change in the DateTimePicker already and not only adding seconds.
Additionally, I fixed some styling issues along the way. Most prominently, the
p-2topt-4which had the DateTimeRangePicker offset horizontally.