Add public Network.close() method to perform controlled network shutdown #129
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renames the close_gracefully() method to just
close()
and makesit public so that an application has a bit more control over Network
shutdown.
libsession-util ran into an issue where the quic::Network destruction
segfaults because it has callbacks (e.g. connection closing) that expect
to be able to use their local
quic::Network
instance, but can'tbecause it's in the process of being destroyed.
Essentially the pattern is this:
If the quic::Network destruction is triggered by the destruction of
a
,then the quic::Network destructor is firing after
a
is no longer ina valid state, and so the callback referencing
a
is invalid.Exposing close() allows the application to deal with this: it can add a
net.close()
either inA
's destructor or some other shutdown code sothat it can ensure the quic Network shutdown happens before
a
becomes unusable.
This also adds a non-synchronous
call_soon()
to mirror the call(ep)and call_soon(ep) methods for shutdown down individual endpoints.