Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apiovh): handle credentials template #489

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

wI2L
Copy link
Contributor

@wI2L wI2L commented Oct 27, 2023

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Fix.
Handle the cas where the apiovh plugin's config field credentials is a template.

  • What is the current behavior? (You can also link to an open issue here)

Whether the field is a plain string or a template, the validConfig is used to check if the configuration item exists and it valid. During the validation, the config field is not templated yet, resulting in an incorrect value.

  • What is the new behavior (if this is a feature change)?

If the config field credentials is a templaate, skip the actual validation process.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

No, the behavior stay the same for current usage.

@wI2L wI2L force-pushed the apiovh-plugin-credentials-template branch from 079f839 to d3d29f3 Compare October 27, 2023 15:00
@floriancazals floriancazals merged commit fe9a8c1 into master Oct 31, 2023
DrRebus pushed a commit to DrRebus/utask that referenced this pull request Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants