-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev/ybriffa/output #159
Merged
Merged
Dev/ybriffa/output #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21f0562
to
ba9905f
Compare
rbeuque74
reviewed
Jun 22, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise, LGTM
rbeuque74
reviewed
Jun 26, 2020
rbeuque74
previously approved these changes
Jun 26, 2020
CDS Report test#751.0 ✘
|
3b66324
to
a7882ed
Compare
rbeuque74
previously approved these changes
Jun 26, 2020
Signed-off-by: Yannick Briffa <[email protected]>
Signed-off-by: Yannick Briffa <[email protected]>
Signed-off-by: Yannick Briffa <[email protected]>
Signed-off-by: Yannick Briffa <[email protected]>
Signed-off-by: Romain Beuque <[email protected]>
a7882ed
to
b254da7
Compare
Rebased to remove dupplicated commit. |
rbeuque74
approved these changes
Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
It allows to rewrite step outputs
What is the current behavior? (You can also link to an open issue here)
only a base_output is available to rewrite step output
What is the new behavior (if this is a feature change)?
a new property output exists and have multiple strategies to modify the output
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
no
Other information: