Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev/ybriffa/output #159

Merged
merged 5 commits into from
Jun 26, 2020
Merged

Dev/ybriffa/output #159

merged 5 commits into from
Jun 26, 2020

Conversation

ybriffa
Copy link
Contributor

@ybriffa ybriffa commented Jun 17, 2020

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    It allows to rewrite step outputs

  • What is the current behavior? (You can also link to an open issue here)
    only a base_output is available to rewrite step output

  • What is the new behavior (if this is a feature change)?
    a new property output exists and have multiple strategies to modify the output

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    no

  • Other information:

@ybriffa ybriffa requested review from loopfz and rbeuque74 as code owners June 17, 2020 12:42
@ybriffa ybriffa force-pushed the dev/ybriffa/output branch from 21f0562 to ba9905f Compare June 22, 2020 08:40
Copy link
Member

@rbeuque74 rbeuque74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM

@rbeuque74 rbeuque74 self-requested a review June 23, 2020 08:42
rbeuque74
rbeuque74 previously approved these changes Jun 26, 2020
@ovh-cds
Copy link
Collaborator

ovh-cds commented Jun 26, 2020

CDS Report test#751.0 ✘

  • Stage 1
    • Test ✘

rbeuque74
rbeuque74 previously approved these changes Jun 26, 2020
@rbeuque74
Copy link
Member

Rebased to remove dupplicated commit.

@rbeuque74 rbeuque74 merged commit a30c816 into master Jun 26, 2020
@rbeuque74 rbeuque74 deleted the dev/ybriffa/output branch June 26, 2020 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants