partitions: Also make / ro by default
#349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ondrejbudai
force-pushed
the
default-root-ro
branch
from
8cdd136 to
7bc68af
Compare
To match what we expect currently with composefs. The more correct thing here longer term is to inspect the container image, in theory. In practice though, after we start relying on `bootc install` osbuild/images#571 I think that will lead us to a place where we start to implicitly hard require composefs. But without inspection/detection this will affect how non-composefs container images (e.g. current quay.io/fedora/* images). So again the more medium term fix here has to be that either we inspect, or more ideally we gather the expected mount options and filesystem types etc. from `bootc` inside the container.
ondrejbudai
force-pushed
the
default-root-ro
branch
from
7bc68af to
216c21a
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To match what we expect currently with composefs.
The more correct thing here longer term is to inspect the container image, in theory.
In practice though, after we start relying on
bootc installosbuild/images#571I think that will lead us to a place where we start to implicitly hard require composefs.
But without inspection/detection this will affect how non-composefs container images (e.g. current quay.io/fedora/* images).
So again the more medium term fix here has to be that either we inspect, or more ideally we gather the expected mount options and filesystem types etc. from
bootcinside the container.