Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Press space to open the first http(s) reference in browser #11

Closed
mertssmnoglu opened this issue May 18, 2024 · 2 comments
Closed

Press space to open the first http(s) reference in browser #11

mertssmnoglu opened this issue May 18, 2024 · 2 comments
Assignees
@orhun
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mertssmnoglu
Copy link
Contributor

Is your feature request related to a problem? Please describe.

I wanted to open the reference links of a random CVE and tried to clicking the urls with ctrl + click but it doesn't open anything. I need to write the whoole url to my web browser manually.

Describe the solution you'd like

Pressing space button can trigger xdg-open HTTP_URL, open HTTP_URL or something like that.

Describe alternatives you've considered

Surfing around the references with j,k or up,down keys and opening them in Web Browser via space

Additional context

The details page that I talking about.
20240518_23h31m07s_grim

There is also ftp:// urls too, thats why I highlighted http(s) in the feature request.
@mertssmnoglu mertssmnoglu added the enhancement New feature or request label May 18, 2024
@orhun orhun added the good first issue Good for newcomers label May 20, 2024
@orhun
Copy link
Owner

orhun commented May 20, 2024

It's a good idea! Are you interested in contributing?

@orhun orhun changed the title On the details page, pressing space can trigger to open the first http(s) reference in Web Browser Press space to open the first http(s) reference in browser May 20, 2024
@mertssmnoglu
Copy link
Contributor Author

It's a good idea! Are you interested in contributing?

Yes, I'm into the contributing. I don't actively coding with Rust, but I will try to implement this feature in my fork.

mertssmnoglu added a commit to mertssmnoglu/fork_flawz that referenced this issue May 20, 2024
@mertssmnoglu
feat: support opening first http reference in browser (orhun#11)
34b5230
@mertssmnoglu mertssmnoglu mentioned this issue May 20, 2024
Merged
3 tasks
orhun added a commit that referenced this issue May 24, 2024
@mertssmnoglu @orhun
feat: support opening the first HTTP reference in browser (#11) (#15)
e970ebc 
* chore(deps): add webbrowser dependency

- version 1.0.1
- https://crates.io/crates/webbrowser

* feat: support opening first http reference in browser (#11)

* refactor: avoid panicking on selecting reference

- improve code simplicity
- better error printing with eprintln

Co-authored-by: Orhun Parmaksız <[email protected]>

* fix: add missing closing brace in handle_key_events function

---------

Co-authored-by: Orhun Parmaksız <[email protected]>
@orhun orhun closed this as completed May 24, 2024
This was referenced May 24, 2024
Closed
Merged
@BrewTestBot BrewTestBot mentioned this issue May 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@orhun orhun

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@orhun @mertssmnoglu