Pre-release script fixes #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `-i` sed flag is for doing in-place updates of the file. On some systems it requires a parameter, on other (GNU) the parameter is optional, but should be "glued" to the flag (`-i.bak` for example). That's is problematic, so just emulate the in-place updates with copies and removals.
This was a missing step, which is why we still have a version string "0.2.3" while in reality it should be "0.3.0". Hopefully it will be something to fix in "0.3.1" or what the next release version will be.
The script does `git add .` which adds everything in the tree, even the untracked files. Make sure that there are none of those.
krnowak
requested review from
jmacd,
lizthegrey,
MrAlias,
paivagustavo,
rghetia and
tedsuo
as code owners
jmacd
approved these changes
Mar 24, 2020
rghetia
approved these changes
Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't run it on my host because of the
-iflag incompatibilities between GNU sed and sed used in BSDs or macos. With that fixed, I implemented the missing part of updating the version string insdk/opentelemetry.go. Also, I had some garbage files in my tree that ended up in thePrepare for releasing vX.Y.Zcommit, so I added the code to check if the git repo is in a clean state.Fixes #581.