Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to determine whether SpanContext is remote #1701

Merged
merged 9 commits into from
Mar 18, 2021

Conversation

Aneurysm9
Copy link
Member

Fixes #1614

@Aneurysm9 Aneurysm9 force-pushed the span_context_is_remote branch from 4228d69 to b5a6d22 Compare March 15, 2021 18:30
@codecov
Copy link

codecov bot commented Mar 15, 2021

Codecov Report

Merging #1701 (698e4e0) into main (0fe65e6) will increase coverage by 0.0%.
The diff coverage is 88.2%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #1701   +/-   ##
=====================================
  Coverage   77.8%   77.8%           
=====================================
  Files        130     130           
  Lines       6998    7013   +15     
=====================================
+ Hits        5450    5463   +13     
- Misses      1297    1299    +2     
  Partials     251     251           
Impacted Files Coverage Δ
trace/trace.go 86.1% <87.5%> (-0.1%) ⬇️
propagation/trace_context.go 69.2% <100.0%> (+0.4%) ⬆️

@MrAlias MrAlias merged commit 860d5d8 into open-telemetry:main Mar 18, 2021
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SpanContext must support IsRemote()
4 participants