Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: un-hardcode repo+owner, sign commits via API #918

Merged
merged 29 commits into from
Dec 2, 2023

Conversation

JJGadgets
Copy link
Contributor

@JJGadgets JJGadgets commented Dec 2, 2023

Changelog

  • Made repository owner and repository name an environment variable that reads from the GitHub Actions default environment variables, but can also be overridden if needed (override currently unused)
  • Lowercase repository owner's username before using it in build-images.yaml, so that OCI pushes won't fail
  • Use GitHub API to commit changes for both render-readme.yaml and Renovate so that commit signing is always done for all commits
  • Added some descriptions & more detailed comments
  • Made English easier for template-sensei

These changes have been tested on my own containers repo, so they should work on this repo too.

also added descriptions & comments
and made English easier for template-sensei
@onedr0p onedr0p merged commit bff8377 into onedr0p:main Dec 2, 2023
JJGadgets added a commit to JJGadgets/containers that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants