Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not print --features with empty list (#718) #726

Merged
merged 1 commit into from
Mar 30, 2024
Merged

Do not print --features with empty list (#718) #726

merged 1 commit into from
Mar 30, 2024

Conversation

jw013
Copy link
Contributor

@jw013 jw013 commented Mar 30, 2024

Fixes #718

pksunkara
pksunkara reviewed Mar 30, 2024
View reviewed changes
Copy link
Contributor

@pksunkara pksunkara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@obi1kenobi obi1kenobi merged commit 9f88272 into obi1kenobi:main Mar 30, 2024
33 checks passed
@obi1kenobi
Copy link
Owner

Awesome, thank you both! 🚀

@jw013 jw013 deleted the empty-features-fix branch April 1, 2024 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pksunkara pksunkara pksunkara left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build failure repro command may include --features flag without any features
3 participants
@jw013 @obi1kenobi @pksunkara