Add lint for missing pub module-level const

src/lints/pub_module_level_const_missing.ron

@@ -0,0 +1,39 @@
+SemverQuery(
+    id: "pub_module_level_const_missing",
+    human_readable_name: "pub module-level const is missing",
+    description: "TODO",
+    required_update: Major,  // TODO
+    reference_link: Some("https://doc.rust-lang.org/reference/TBD"),
+    query: r#"
+    {
+        CrateDiff {
+            baseline {
+                item {
+                    ... on Constant {
+                        visibility_limit @filter(op: "=", value: ["$public"]) @output
+                        name @output @tag
+
+                        span_: span @optional {
+                            filename @output
+                            begin_line @output
+                        }
+                    }
+                }
+            }
+            current {
+                item @fold @transform(op: "count") @filter(op: "=", value: ["$zero"]) {
+                    ... on Constant {
+                        visibility_limit @filter(op: "=", value: ["$public"])
+                        name @filter(op: "=", value: ["%name"])
+                    }
+                }
+            }
+        }
+    }"#,
+    arguments: {
+        "public": "public",
+        "zero": 0,
+    },
+    error_message: "A publicly-visible const in a module is missing or renamed. It may have changed from const to static.",
+    per_result_error_template: Some("{{name}} in file {{span_filename}}:{{span_begin_line}}"),
+)

src/query.rs

@@ -505,4 +505,5 @@ add_lints!(
     enum_tuple_variant_field_missing,
     enum_tuple_variant_field_added,
     trait_removed_supertrait,
+    pub_module_level_const_missing,
 );

test_crates/pub_module_level_const_missing/new/Cargo.toml

@@ -0,0 +1,7 @@
+[package]
+publish = false
+name = "pub_module_level_const_missing"
+version = "0.1.0"
+edition = "2021"
+
+[dependencies]

test_crates/pub_module_level_const_missing/new/src/lib.rs

@@ -0,0 +1,32 @@
+pub const PUB_CONST_IN_GLOBAL: i32 = 0;
+pub const PUB_CONST_IN_GLOBAL_IS_RENAMED: i32 = 0;
+pub static PUB_CONST_IN_GLOBAL_WILL_BE_STATIC: i32 = 0;
+const PUB_CONST_IN_GLOBAL_WILL_BE_PRIVATE_CONST: i32 = 0;
+static PUB_CONST_IN_GLOBAL_WILL_BE_PRIVATE_STATIC: i32 = 0;
+
+mod re_exporter {
+    pub const SPECIAL_CONST: i32 = 0;
+    pub static SPECIAL_STATIC: i32 = 0;
+}
+
+pub mod my_module {
+    pub const PUB_CONST_IN_MODULE: i32 = 0;
+    pub const PUB_CONST_IN_MODULE_IS_RENAMED: i32 = 0;
+    pub static PUB_CONST_IN_MODULE_WILL_BE_STATIC: i32 = 0;
+    const PUB_CONST_IN_MODULE_WILL_BE_PRIVATE_CONST: i32 = 0;
+    static PUB_CONST_IN_MODULE_WILL_BE_PRIVATE_STATIC: i32 = 0;
+
+    pub use crate::re_exporter::SPECIAL_CONST as PUB_CONST_IN_MODULE_WILL_RE_EXPORT;
+    pub use crate::re_exporter::SPECIAL_STATIC as PUB_CONST_IN_MODULE_WILL_RE_EXPORT_STATIC;
+
+    pub mod my_module_nested {
+        pub const PUB_CONST_IN_NESTED_MODULE: i32 = 0;
+        static PUB_CONST_IN_NESTED_MODULE_WILL_REMOVE_CONST: i32 = 0;
+        pub const PUB_CONST_IN_NESTED_MODULE_IS_RENAMED: i32 = 0;
+        pub static PUB_CONST_IN_NESTED_MODULE_WILL_BE_STATIC: i32 = 0;
+        const PUB_CONST_IN_NESTED_MODULE_WILL_BE_PRIVATE: i32 = 0;
+
+        pub use crate::re_exporter::SPECIAL_CONST as PUB_CONST_IN_NESTED_MODULE_WILL_RE_EXPORT;
+        pub use crate::re_exporter::SPECIAL_STATIC as PUB_CONST_IN_NESTED_MODULE_WILL_RE_EXPORT_STATIC;
+    }
+}

test_crates/pub_module_level_const_missing/old/Cargo.toml

@@ -0,0 +1,7 @@
+[package]
+publish = false
+name = "pub_module_level_const_missing"
+version = "0.1.0"
+edition = "2021"
+
+[dependencies]

test_crates/pub_module_level_const_missing/old/src/lib.rs

@@ -0,0 +1,28 @@
+pub const PUB_CONST_IN_GLOBAL: i32 = 0;
+pub const PUB_CONST_IN_GLOBAL_WILL_REMOVE: i32 = 0;
+pub const PUB_CONST_IN_GLOBAL_WILL_RENAME: i32 = 0;
+pub const PUB_CONST_IN_GLOBAL_WILL_BE_STATIC: i32 = 0;
+pub const PUB_CONST_IN_GLOBAL_WILL_BE_PRIVATE_CONST: i32 = 0;
+pub const PUB_CONST_IN_GLOBAL_WILL_BE_PRIVATE_STATIC: i32 = 0;
+
+pub mod my_module {
+    pub const PUB_CONST_IN_MODULE: i32 = 0;
+    pub const PUB_CONST_IN_MODULE_WILL_REMOVE: i32 = 0;
+    pub const PUB_CONST_IN_MODULE_WILL_RENAME: i32 = 0;
+    pub const PUB_CONST_IN_MODULE_WILL_BE_STATIC: i32 = 0;
+    pub const PUB_CONST_IN_MODULE_WILL_BE_PRIVATE_CONST: i32 = 0;
+    pub const PUB_CONST_IN_MODULE_WILL_BE_PRIVATE_STATIC: i32 = 0;
+    pub const PUB_CONST_IN_MODULE_WILL_RE_EXPORT: i32 = 0;
+    pub const PUB_CONST_IN_MODULE_WILL_RE_EXPORT_STATIC: i32 = 0;
+
+    pub mod my_module_nested {
+        pub const PUB_CONST_IN_NESTED_MODULE: i32 = 0;
+        pub const PUB_CONST_IN_NESTED_MODULE_WILL_REMOVE: i32 = 0;
+        pub const PUB_CONST_IN_NESTED_MODULE_WILL_RENAME: i32 = 0;
+        pub const PUB_CONST_IN_NESTED_MODULE_WILL_BE_STATIC: i32 = 0;
+        pub const PUB_CONST_IN_NESTED_MODULE_WILL_BE_PRIVATE_CONST: i32 = 0;
+        pub const PUB_CONST_IN_NESTED_MODULE_WILL_BE_PRIVATE_STATIC: i32 = 0;
+        pub const PUB_CONST_IN_NESTED_MODULE_WILL_RE_EXPORT: i32 = 0;
+        pub const PUB_CONST_IN_NESTED_MODULE_WILL_RE_EXPORT_STATIC: i32 = 0;
+    }
+}

test_outputs/pub_module_level_const_missing.output.ron

@@ -0,0 +1,122 @@
+{
+    "./test_crates/pub_module_level_const_missing/": [
+        {
+            "name": String("PUB_CONST_IN_GLOBAL_WILL_REMOVE"),
+            "span_begin_line": Uint64(2),
+            "span_filename": String("src/lib.rs"),
+            "visibility_limit": String("public"),
+        },
+        {
+            "name": String("PUB_CONST_IN_GLOBAL_WILL_RENAME"),
+            "span_begin_line": Uint64(3),
+            "span_filename": String("src/lib.rs"),
+            "visibility_limit": String("public"),
+        },
+        {
+            "name": String("PUB_CONST_IN_GLOBAL_WILL_BE_STATIC"),
+            "span_begin_line": Uint64(4),
+            "span_filename": String("src/lib.rs"),
+            "visibility_limit": String("public"),
+        },
+        {
+            "name": String("PUB_CONST_IN_GLOBAL_WILL_BE_PRIVATE_CONST"),
+            "span_begin_line": Uint64(5),
+            "span_filename": String("src/lib.rs"),
+            "visibility_limit": String("public"),
+        },
+        {
+            "name": String("PUB_CONST_IN_GLOBAL_WILL_BE_PRIVATE_STATIC"),
+            "span_begin_line": Uint64(6),
+            "span_filename": String("src/lib.rs"),
+            "visibility_limit": String("public"),
+        },
+        {
+            "name": String("PUB_CONST_IN_MODULE_WILL_REMOVE"),
+            "span_begin_line": Uint64(10),
+            "span_filename": String("src/lib.rs"),
+            "visibility_limit": String("public"),
+        },
+        {
+            "name": String("PUB_CONST_IN_MODULE_WILL_RENAME"),
+            "span_begin_line": Uint64(11),
+            "span_filename": String("src/lib.rs"),
+            "visibility_limit": String("public"),
+        },
+        {
+            "name": String("PUB_CONST_IN_MODULE_WILL_BE_STATIC"),
+            "span_begin_line": Uint64(12),
+            "span_filename": String("src/lib.rs"),
+            "visibility_limit": String("public"),
+        },
+        {
+            "name": String("PUB_CONST_IN_MODULE_WILL_BE_PRIVATE_CONST"),
+            "span_begin_line": Uint64(13),
+            "span_filename": String("src/lib.rs"),
+            "visibility_limit": String("public"),
+        },
+        {
+            "name": String("PUB_CONST_IN_MODULE_WILL_BE_PRIVATE_STATIC"),
+            "span_begin_line": Uint64(14),
+            "span_filename": String("src/lib.rs"),
+            "visibility_limit": String("public"),
+        },
+        /*
+        // Commenting out this for now; see PR491 for details
+        {
+            "name": String("PUB_CONST_IN_MODULE_WILL_RE_EXPORT"),
+            "span_begin_line": Uint64(15),
+            "span_filename": String("src/lib.rs"),
+            "visibility_limit": String("public"),
+        },*/
+        {
+            "name": String("PUB_CONST_IN_MODULE_WILL_RE_EXPORT_STATIC"),
+            "span_begin_line": Uint64(16),
+            "span_filename": String("src/lib.rs"),
+            "visibility_limit": String("public"),
+        },
+        {
+            "name": String("PUB_CONST_IN_NESTED_MODULE_WILL_REMOVE"),
+            "span_begin_line": Uint64(20),
+            "span_filename": String("src/lib.rs"),
+            "visibility_limit": String("public"),
+        },
+        {
+            "name": String("PUB_CONST_IN_NESTED_MODULE_WILL_RENAME"),
+            "span_begin_line": Uint64(21),
+            "span_filename": String("src/lib.rs"),
+            "visibility_limit": String("public"),
+        },
+        {
+            "name": String("PUB_CONST_IN_NESTED_MODULE_WILL_BE_STATIC"),
+            "span_begin_line": Uint64(22),
+            "span_filename": String("src/lib.rs"),
+            "visibility_limit": String("public"),
+        },
+        {
+            "name": String("PUB_CONST_IN_NESTED_MODULE_WILL_BE_PRIVATE_CONST"),
+            "span_begin_line": Uint64(23),
+            "span_filename": String("src/lib.rs"),
+            "visibility_limit": String("public"),
+        },
+        {
+            "name": String("PUB_CONST_IN_NESTED_MODULE_WILL_BE_PRIVATE_STATIC"),
+            "span_begin_line": Uint64(24),
+            "span_filename": String("src/lib.rs"),
+            "visibility_limit": String("public"),
+        },
+        /*
+        // Commenting out this for now; see PR491 for details
+        {
+            "name": String("PUB_CONST_IN_NESTED_MODULE_WILL_RE_EXPORT"),
+            "span_begin_line": Uint64(25),
+            "span_filename": String("src/lib.rs"),
+            "visibility_limit": String("public"),
+        },*/
+        {
+            "name": String("PUB_CONST_IN_NESTED_MODULE_WILL_RE_EXPORT_STATIC"),
+            "span_begin_line": Uint64(26),
+            "span_filename": String("src/lib.rs"),
+            "visibility_limit": String("public"),
+        },
+    ],
+}