Use #![no_std] in test crates to speed up tests.
#1171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The difference is significant. In the original code: ``` generate rustdoc JSON: real 2m45.816s user 1m54.422s sys 0m26.240s cargo test: real 2m4.599s user 23m2.108s sys 0m27.490s 84MB in localdata/test_data ``` With `#![no_std]` where easily feasible: ``` generate rustdoc JSON: real 1m45.892s user 1m8.053s sys 0m15.327s cargo test: real 1m49.396s user 23m3.742s sys 0m19.184s 41MB in localdata/test_data ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The difference is significant.
In the original code:
With
#![no_std]where easily feasible: