Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new lint: unconditionally_sealed_trait_became_unsealed #1164

Merged
merged 6 commits into from
Mar 1, 2025
Merged

new lint: unconditionally_sealed_trait_became_unsealed #1164

merged 6 commits into from
Mar 1, 2025

Conversation

lovelindhoni
Copy link
Contributor

Resolves #1121

@lovelindhoni
Copy link
Contributor Author

On the query, I explicitly checked both unconditionally_sealed and public_api_sealed for the current crate state.
I hope that's okay :)

@obi1kenobi
Copy link
Owner

On the query, I explicitly checked both unconditionally_sealed and public_api_sealed for the current crate state. I hope that's okay :)

Yeah, that's accurate and necessary. Without it, the query would be incorrect.

@obi1kenobi obi1kenobi merged commit bf9416a into obi1kenobi:main Mar 1, 2025
32 of 33 checks passed
@lovelindhoni lovelindhoni deleted the unconditionally-sealed-trait-became-unsealed branch March 2, 2025 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obi1kenobi obi1kenobi obi1kenobi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unconditionally sealed trait became unsealed (risk: reverting this is a major breaking change)
2 participants
@lovelindhoni @obi1kenobi