replace object_safe with dyn_compatible
#1083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good questions — go ahead and rename the query, its test crate, and related functions. It's probably fine, and probably best done sooner rather than later. The code change looks good so far. |
|
This should start passing tests as soon as #1084 is merged. |
obi1kenobi
approved these changes
Jan 27, 2025
|
I think you'll need to rename one of the snapshot files as well here to make tests pass. Otherwise LGTM and happy to merge. |
|
Thanks for taking care of this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: obi1kenobi/trustfall-rustdoc-adapter#718
Should we not rename the query name yet? but should I rename the test name and all
make_me_non_object_safefunctions?