Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add_flow and del_flow commands added #94

Open
wants to merge 3 commits into
base: carp
Choose a base branch
from

Conversation

nomorecaddy
Copy link

added these commands to the webservice demo which adds / deletes a flow on the switch

@MurphyMc
Copy link
Collaborator

MurphyMc commented Oct 2, 2013

Hmm... I had specifically left out individual add and remove flow commands with the idea that managing state incrementally is difficult. Instead, I just had the set_table command. This forces the client to be aware of the complete state they actually want, but it also (theoretically, anyway) gets rid of ugly race conditions and ambiguity.

@MurphyMc
Copy link
Collaborator

MurphyMc commented Nov 6, 2013

Just a note that if this is going to proceed, it should target dart.

@MurphyMc
Copy link
Collaborator

I've decided I'd merge this with a few changes:

  1. As mentioned, list_switch() should just be an optional parameter to list_switches(), not a whole new method.
  2. It should target dart.
  3. POX doesn't (or at least shouldn't) use the term "flow" to mean "table entry", so the commands should be named something like add_table_entry() or add_entry(). And actually, OpenFlow 1.0's "add" is ambiguous, since it can also be a "modify". So maybe set_table_entry()?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants