Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2025-02-26, Version 23.9.0 (Current) #57207

Merged
merged 92 commits into from
Feb 26, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
92 commits
Select commit Hold shift + click to select a range
ab150d7
test: remove flakiness on macOS test
anonrig Feb 9, 2025
0a82d27
test: reduce flakiness on test-net-write-fully-async-buffer
anonrig Feb 9, 2025
d0ee8c0
src: improve error handling in process_wrap
jasnell Feb 11, 2025
41f444f
src: improve error handling in string_bytes/decoder
jasnell Feb 11, 2025
d8e70dc
src: improve node::Dotenv trimming
dario-piotrowicz Feb 11, 2025
9b98ac6
test: update WPT for urlpattern to ef6d83d789
nodejs-github-bot Feb 12, 2025
2990cc8
doc: run license-builder
github-actions[bot] Feb 12, 2025
35f89aa
build: fix GN build of uv
zcbenz Feb 12, 2025
3bc6d62
doc: add `signal` to `filehandle.writeFile()` options
y-hsgw Feb 12, 2025
7e2dac9
src: add self-assigment memcpy checks
wooffie Feb 12, 2025
a6b7bce
doc: move stability index after history section for consistency
aduh95 Feb 12, 2025
a9112df
tools: add support for `import source` syntax in linter
aduh95 Feb 12, 2025
c011271
doc: update cleanup to trust on vuln db automation
RafaelGSS Feb 13, 2025
18ea88b
crypto: cleanup root certificates and skip PEM deserialization
joyeecheung Feb 13, 2025
2ec4ff1
meta: update last name for jkrems
jkrems Feb 13, 2025
dfdaa92
crypto: fix missing OPENSSL_NO_ENGINE guard
codebytere Feb 14, 2025
1efd74b
tools: fix release URL computation in update-root-certs.mjs
joyeecheung Feb 14, 2025
44dd8a5
doc: buffer: fix typo on `Buffer.copyBytesFrom(` `offset` option
tpoisseau Feb 14, 2025
6951133
doc: improve documentation on argument validation
Aditi-1400 Feb 14, 2025
b369ad6
test: remove unnecessary assert requiring from tests
dario-piotrowicz Feb 14, 2025
ccb8c12
test,crypto: make tests work for BoringSSL
codebytere Feb 15, 2025
5af35d1
build: fix GN build failure
zcbenz Feb 15, 2025
50ba04e
doc: recommend writing tests in new files and including comments
joyeecheung Feb 15, 2025
6cdee54
tools: do not run major-release workflow on forks
Trott Feb 15, 2025
a588066
test: add case for unrecognised fields within pjson "exports"
JakobJingleheimer Feb 13, 2025
40f3a51
fs: handle UV_ENOTDIR in `fs.statSync` with `throwIfNoEntry` provided
juanarbol Feb 10, 2025
5b2dfad
doc: add a note about `require('../common')` in testing documentation
Aditi-1400 Feb 15, 2025
b50fc42
crypto: support --use-system-ca on non-Windows and non-macOS
joyeecheung Feb 15, 2025
fa26f83
src: lock the isolate properly in IsolateData destructor
joyeecheung Feb 15, 2025
286bb84
src: fix accessing empty string
zcbenz Feb 16, 2025
c02494f
doc: fix transpiler loader hooks documentation
joyeecheung Feb 16, 2025
a7e5ef9
doc: fix wrong verb form
dario-piotrowicz Feb 16, 2025
9de45cb
doc: `modules.md`: fix `distance` definition
alexweej Feb 16, 2025
f4a82fd
benchmark: add a warmup on bench-openSync
elvessilvavieira Feb 16, 2025
ed5671f
doc: update `module.builtinModules` sentence
dario-piotrowicz Feb 16, 2025
78d4e52
doc: fix wrong articles used to address modules
dario-piotrowicz Feb 17, 2025
4b02fdc
doc: update Xcode version used for arm64 and pkg
targos Feb 17, 2025
5414eb4
src: improve error handling in multiple files
jasnell Feb 8, 2025
90875ba
src: improve error handling in node_blob
jasnell Feb 15, 2025
46df14d
doc: update clang-cl on Windows building guide
joyeecheung Feb 18, 2025
fec2d50
build: add skip_apidoc_files and include QUIC
RafaelGSS Feb 6, 2025
ac35106
sea: suppress builtin warning with disableExperimentalSEAWarning option
koooge Feb 16, 2025
5a74568
doc: disambiguate pseudo-code statement
dario-piotrowicz Feb 18, 2025
cc1cafd
module: allow omitting context in synchronous next hooks
joyeecheung Feb 18, 2025
21d795a
dns: add TLSA record query and parsing
rithvikvibhu May 14, 2024
0de128c
doc: add `module namespace object` links
dario-piotrowicz Feb 16, 2025
b696049
doc: fix link and history of `SourceMap` sections
aduh95 Feb 18, 2025
56f9fe7
src: port `defineLazyProperties` to native code
aduh95 Feb 18, 2025
e3127b8
src: replace NewFromUtf8 with OneByteString where appropriate
jasnell Feb 18, 2025
2929fc6
test_runner: allow special characters in snapshot keys
Ceres6 Feb 19, 2025
b384baa
build: print 'Formatting Markdown...' for long task markdown formatting
1ilsang Feb 19, 2025
e26d484
cli: allow --cpu-prof* in NODE_OPTIONS
Ceres6 Feb 20, 2025
73a8514
tools: consolidate 'introduced_in' check for docs
1ilsang Feb 20, 2025
fdc8aeb
doc: fix 'introduced_in' version in typescript module
1ilsang Feb 20, 2025
7dd326e
src: move instead of copy shared pointer in node_blob
targos Feb 20, 2025
e0a91f6
src: gate all quic behind disabled-by-default compile flag
jasnell Feb 19, 2025
d62299b
meta: add CODEOWNERS for SQLite
cjihrig Feb 20, 2025
90a4de0
src: do not format single string argument for THROW_ERR_*
joyeecheung Feb 18, 2025
ad3c572
module: improve error message from asynchronicity in require(esm)
joyeecheung Feb 17, 2025
8421021
deps: update ada to 3.1.0
nodejs-github-bot Feb 20, 2025
ccf496c
test: improve error output of test-http2-client-promisify-connect-error
aduh95 Feb 21, 2025
c6ddfa5
process: add threadCpuUsage
ShogunPanda Feb 21, 2025
d922153
url: improve urlpattern regexp performance
anonrig Feb 21, 2025
c6d6be2
typings: fix `ImportModuleDynamicallyCallback` return type
legendecas Feb 21, 2025
315244e
test: simplify test-http2-client-promisify-connect-error
lpinca Feb 22, 2025
587112c
doc: remove buffered flag from performance hooks examples
pavel-romanov8 Feb 23, 2025
85ac02f
meta: bump `github/codeql-action` from 3.27.5 to 3.28.8
dependabot[bot] Feb 23, 2025
7f5f02b
meta: bump `actions/stale` from 9.0.0 to 9.1.0
dependabot[bot] Feb 23, 2025
dfd42db
meta: bump `actions/cache` from 4.1.2 to 4.2.0
dependabot[bot] Feb 23, 2025
58d7036
meta: bump `step-security/harden-runner` from 2.10.2 to 2.10.4
dependabot[bot] Feb 23, 2025
0dd0108
meta: bump `codecov/codecov-action` from 5.0.7 to 5.3.1
dependabot[bot] Feb 23, 2025
3d61604
meta: bump `mozilla-actions/sccache-action` from 0.0.6 to 0.0.7
dependabot[bot] Feb 23, 2025
35cdd9b
meta: bump `peter-evans/create-pull-request` from 7.0.5 to 7.0.6
dependabot[bot] Feb 23, 2025
f77069b
meta: bump `actions/setup-python` from 5.3.0 to 5.4.0
dependabot[bot] Feb 23, 2025
d6234b4
inspector: skip promise hook in the inspector async hook
joyeecheung Feb 23, 2025
a025d7b
tools: run Linux tests on GitHub arm64 runners as well
dennisameling Feb 23, 2025
ef314dc
src: fix crash when lazy getter is invoked in a vm context
legendecas Feb 23, 2025
66614cf
doc: fix web.libera.chat link in pull-requests.md
SamB Feb 23, 2025
7c7e9f4
test: make eval snapshot comparison more flexible
codebytere Feb 23, 2025
51dff8b
test: fix test-without-async-context-frame.mjs in debug mode
joyeecheung Feb 15, 2025
116c1fe
test_runner: refactor testPlan counter increse
pmarchini Feb 23, 2025
4413ce7
doc: fix typo in Windows building instructions
timja Feb 24, 2025
e10ef27
inspector: convert event params to protocol without json
legendecas Feb 24, 2025
f35bd86
doc: add additional caveat for fs.watch
mhdawson Feb 24, 2025
1a24417
test: add doAppendAndCancel test
y-hsgw Feb 24, 2025
455bf5a
doc: update options to filehandle.appendFile()
y-hsgw Feb 24, 2025
e08d7d4
lib: fixup incorrect argument order in assertEncoding
jasnell Feb 22, 2025
aa81785
lib: fixup more incorrect ERR_INVALID_ARG_VALUE uses
jasnell Feb 23, 2025
2aceca1
deps: update sqlite to 3.49.1
nodejs-github-bot Feb 25, 2025
8644cf3
deps: update ngtcp2 to 1.11.0
nodejs-github-bot Feb 25, 2025
8076284
deps: update cjs-module-lexer to 2.1.0
nodejs-github-bot Feb 25, 2025
9d2368f
2025-02-26, Version 23.9.0 (Current)
nodejs-github-bot Feb 25, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -200,3 +200,11 @@
/lib/url.js @nodejs/url
/src/node_url.* @nodejs/url
/test/fixtures/wpt/url @nodejs/url

# SQLite
/deps/sqlite/ @nodejs/sqlite
/doc/api/sqlite.md @nodejs/sqlite
/src/node_sqlite.* @nodejs/sqlite
/test/parallel/test-sqlite* @nodejs/sqlite
/test/sqlite/ @nodejs/sqlite
/tools/dep_updaters/update-sqlite.sh @nodejs/sqlite
6 changes: 3 additions & 3 deletions .github/workflows/build-tarball.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:
with:
persist-credentials: false
- name: Set up Python ${{ env.PYTHON_VERSION }}
uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b # v5.3.0
uses: actions/setup-python@42375524e23c412d93fb67b49958b491fce71c38 # v5.4.0
with:
python-version: ${{ env.PYTHON_VERSION }}
- name: Set up sccache
Expand Down Expand Up @@ -76,11 +76,11 @@ jobs:
with:
persist-credentials: false
- name: Set up Python ${{ env.PYTHON_VERSION }}
uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b # v5.3.0
uses: actions/setup-python@42375524e23c412d93fb67b49958b491fce71c38 # v5.4.0
with:
python-version: ${{ env.PYTHON_VERSION }}
- name: Set up sccache
uses: mozilla-actions/sccache-action@9e326ebed976843c9932b3aa0e021c6f50310eb4 # v0.0.6
uses: mozilla-actions/sccache-action@054db53350805f83040bf3e6e9b8cf5a139aa7c9 # v0.0.7
with:
version: v0.8.1
- name: Environment Information
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/close-stale-feature-requests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
if: github.repository == 'nodejs/node'
runs-on: ubuntu-latest
steps:
- uses: actions/stale@28ca1036281a5e5922ead5184a1bbf96e5fc984e # v9.0.0
- uses: actions/stale@5bef64f19d7facfb25b37b414482c7164d639639 # v9.1.0
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
days-before-stale: 180
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/close-stalled.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
if: github.repository == 'nodejs/node'
runs-on: ubuntu-latest
steps:
- uses: actions/stale@28ca1036281a5e5922ead5184a1bbf96e5fc984e # v9.0.0
- uses: actions/stale@5bef64f19d7facfb25b37b414482c7164d639639 # v9.1.0
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
days-before-close: 30
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/coverage-linux-without-intl.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ jobs:
with:
persist-credentials: false
- name: Set up Python ${{ env.PYTHON_VERSION }}
uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b # v5.3.0
uses: actions/setup-python@42375524e23c412d93fb67b49958b491fce71c38 # v5.4.0
with:
python-version: ${{ env.PYTHON_VERSION }}
- name: Set up sccache
Expand All @@ -79,6 +79,6 @@ jobs:
- name: Clean tmp
run: rm -rf coverage/tmp && rm -rf out
- name: Upload
uses: codecov/codecov-action@015f24e6818733317a2da2edd6290ab26238649a # v5.0.7
uses: codecov/codecov-action@13ce06bfc6bbe3ecf90edbbf1bc32fe5978ca1d3 # v5.3.1
with:
directory: ./coverage
4 changes: 2 additions & 2 deletions .github/workflows/coverage-linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ jobs:
with:
persist-credentials: false
- name: Set up Python ${{ env.PYTHON_VERSION }}
uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b # v5.3.0
uses: actions/setup-python@42375524e23c412d93fb67b49958b491fce71c38 # v5.4.0
with:
python-version: ${{ env.PYTHON_VERSION }}
- name: Set up sccache
Expand All @@ -79,6 +79,6 @@ jobs:
- name: Clean tmp
run: rm -rf coverage/tmp && rm -rf out
- name: Upload
uses: codecov/codecov-action@015f24e6818733317a2da2edd6290ab26238649a # v5.0.7
uses: codecov/codecov-action@13ce06bfc6bbe3ecf90edbbf1bc32fe5978ca1d3 # v5.3.1
with:
directory: ./coverage
4 changes: 2 additions & 2 deletions .github/workflows/coverage-windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ jobs:
with:
persist-credentials: false
- name: Set up Python ${{ env.PYTHON_VERSION }}
uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b # v5.3.0
uses: actions/setup-python@42375524e23c412d93fb67b49958b491fce71c38 # v5.4.0
with:
python-version: ${{ env.PYTHON_VERSION }}
- name: Install deps
Expand All @@ -71,6 +71,6 @@ jobs:
- name: Clean tmp
run: npx rimraf ./coverage/tmp
- name: Upload
uses: codecov/codecov-action@015f24e6818733317a2da2edd6290ab26238649a # v5.0.7
uses: codecov/codecov-action@13ce06bfc6bbe3ecf90edbbf1bc32fe5978ca1d3 # v5.3.1
with:
directory: ./coverage
2 changes: 1 addition & 1 deletion .github/workflows/daily-wpt-fyi.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Set up Python ${{ env.PYTHON_VERSION }}
uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b # v5.3.0
uses: actions/setup-python@42375524e23c412d93fb67b49958b491fce71c38 # v5.4.0
with:
python-version: ${{ env.PYTHON_VERSION }}
- name: Environment Information
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/linters.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
with:
persist-credentials: false
- name: Set up Python ${{ env.PYTHON_VERSION }}
uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b # v5.3.0
uses: actions/setup-python@42375524e23c412d93fb67b49958b491fce71c38 # v5.4.0
with:
python-version: ${{ env.PYTHON_VERSION }}
- name: Environment Information
Expand All @@ -64,7 +64,7 @@ jobs:
with:
node-version: ${{ env.NODE_VERSION }}
- name: Set up Python ${{ env.PYTHON_VERSION }}
uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b # v5.3.0
uses: actions/setup-python@42375524e23c412d93fb67b49958b491fce71c38 # v5.4.0
with:
python-version: ${{ env.PYTHON_VERSION }}
- name: Environment Information
Expand Down Expand Up @@ -122,7 +122,7 @@ jobs:
with:
persist-credentials: false
- name: Set up Python ${{ env.PYTHON_VERSION }}
uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b # v5.3.0
uses: actions/setup-python@42375524e23c412d93fb67b49958b491fce71c38 # v5.4.0
with:
python-version: ${{ env.PYTHON_VERSION }}
- name: Environment Information
Expand All @@ -139,7 +139,7 @@ jobs:
with:
persist-credentials: false
- name: Use Python ${{ env.PYTHON_VERSION }}
uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b # v5.3.0
uses: actions/setup-python@42375524e23c412d93fb67b49958b491fce71c38 # v5.4.0
with:
python-version: ${{ env.PYTHON_VERSION }}
- name: Environment Information
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/major-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ permissions:

jobs:
create-issue:
if: github.repository == 'nodejs/node'
runs-on: ubuntu-latest
permissions:
issues: write
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/scorecard.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:

steps:
- name: Harden Runner
uses: step-security/harden-runner@0080882f6c36860b6ba35c610c98ce87d4e2f26f # v2.10.2
uses: step-security/harden-runner@cb605e52c26070c328afc4562f0b4ada7618a84e # v2.10.4
with:
egress-policy: audit # TODO: change to 'egress-policy: block' after couple of runs

Expand Down Expand Up @@ -73,6 +73,6 @@ jobs:

# Upload the results to GitHub's code scanning dashboard.
- name: Upload to code-scanning
uses: github/codeql-action/upload-sarif@f09c1c0a94de965c15400f5634aa42fac8fb8f88 # v3.27.5
uses: github/codeql-action/upload-sarif@dd746615b3b9d728a6a37ca2045b68ca76d4841a # v3.28.8
with:
sarif_file: results.sarif
2 changes: 1 addition & 1 deletion .github/workflows/test-internet.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ jobs:
with:
persist-credentials: false
- name: Set up Python ${{ env.PYTHON_VERSION }}
uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b # v5.3.0
uses: actions/setup-python@42375524e23c412d93fb67b49958b491fce71c38 # v5.4.0
with:
python-version: ${{ env.PYTHON_VERSION }}
- name: Environment Information
Expand Down
8 changes: 6 additions & 2 deletions .github/workflows/test-linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,14 +35,18 @@ permissions:
jobs:
test-linux:
if: github.event.pull_request.draft == false
runs-on: ubuntu-24.04
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
os: [ubuntu-24.04, ubuntu-24.04-arm]
steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
persist-credentials: false
path: node
- name: Set up Python ${{ env.PYTHON_VERSION }}
uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b # v5.3.0
uses: actions/setup-python@42375524e23c412d93fb67b49958b491fce71c38 # v5.4.0
with:
python-version: ${{ env.PYTHON_VERSION }}
- name: Set up sccache
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-macos.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ jobs:
persist-credentials: false
path: node
- name: Set up Python ${{ env.PYTHON_VERSION }}
uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b # v5.3.0
uses: actions/setup-python@42375524e23c412d93fb67b49958b491fce71c38 # v5.4.0
with:
python-version: ${{ env.PYTHON_VERSION }}
- name: Set up Xcode ${{ env.XCODE_VERSION }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/tools.yml
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,7 @@ jobs:
persist-credentials: false
- name: Set up Python ${{ env.PYTHON_VERSION }}
if: matrix.id == 'icu' && (github.event_name == 'schedule' || inputs.id == 'all' || inputs.id == matrix.id)
uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b # v5.3.0
uses: actions/setup-python@42375524e23c412d93fb67b49958b491fce71c38 # v5.4.0
with:
python-version: ${{ env.PYTHON_VERSION }}
- run: ${{ matrix.run }}
Expand All @@ -305,7 +305,7 @@ jobs:
if: env.COMMIT_MSG == '' && (github.event_name == 'schedule' || inputs.id == 'all' || inputs.id == matrix.id)
run: |
echo "COMMIT_MSG=${{ matrix.subsystem }}: update ${{ matrix.id }} to ${{ env.NEW_VERSION }}" >> "$GITHUB_ENV"
- uses: peter-evans/create-pull-request@5e914681df9dc83aa4e4905692ca88beb2f9e91f # v7.0.5
- uses: peter-evans/create-pull-request@67ccf781d68cd99b580ae25a5c18a1cc84ffff1f # v7.0.6
if: github.event_name == 'schedule' || inputs.id == 'all' || inputs.id == matrix.id
# Creates a PR or update the Action's existing PR, or
# no-op if the base branch is already up-to-date.
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/update-v8.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
with:
persist-credentials: false
- name: Cache node modules and update-v8
uses: actions/cache@6849a6489940f00c2f30c0fb92c6274307ccb58a # v4.1.2
uses: actions/cache@1bd1e32a3bdc45362d1e726936510720a7c30a57 # v4.2.0
id: cache-v8-npm
env:
cache-name: cache-v8-npm
Expand All @@ -45,7 +45,7 @@ jobs:
cat temp-output
tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true
rm temp-output
- uses: peter-evans/create-pull-request@5e914681df9dc83aa4e4905692ca88beb2f9e91f # v7.0.5
- uses: peter-evans/create-pull-request@67ccf781d68cd99b580ae25a5c18a1cc84ffff1f # v7.0.6
# Creates a PR or update the Action's existing PR, or
# no-op if the base branch is already up-to-date.
with:
Expand Down
3 changes: 2 additions & 1 deletion .mailmap
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,8 @@ James Ide <[email protected]> <[email protected]>
James M Snell <[email protected]>
James Nimlos <[email protected]>
James Sumners <[email protected]> <[email protected]>
Jan Krems <[email protected]> <[email protected]>
Jan Martin <[email protected]>
Jan Martin <[email protected]> <[email protected]>
Jem Bezooyen <[email protected]> <[email protected]>
Jem Bezooyen <[email protected]> <[email protected]>
Jenna Vuong <[email protected]> <[email protected]>
Expand Down
44 changes: 35 additions & 9 deletions BUILDING.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ file a new issue.
* [Building a debug build](#building-a-debug-build)
* [Building an ASan build](#building-an-asan-build)
* [Speeding up frequent rebuilds when developing](#speeding-up-frequent-rebuilds-when-developing)
* [ccache](#ccache)
* [Loading JS files from disk instead of embedding](#loading-js-files-from-disk-instead-of-embedding)
* [Troubleshooting Unix and macOS builds](#troubleshooting-unix-and-macos-builds)
* [Windows](#windows)
* [Windows Prerequisites](#windows-prerequisites)
Expand Down Expand Up @@ -163,7 +165,7 @@ Binaries at <https://nodejs.org/download/release/> are produced on:
| ----------------------- | ------------------------------------------------------------------------------------------------------------- |
| aix-ppc64 | AIX 7.2 TL04 on PPC64BE with GCC 12[^5] |
| darwin-x64 | macOS 13, Xcode 16 with -mmacosx-version-min=11.0 |
| darwin-arm64 (and .pkg) | macOS 13 (arm64), Xcode 14 with -mmacosx-version-min=11.0 |
| darwin-arm64 (and .pkg) | macOS 13 (arm64), Xcode 16 with -mmacosx-version-min=11.0 |
| linux-arm64 | RHEL 8 with gcc-toolset-12[^6] |
| linux-armv7l | Cross-compiled on RHEL 9 x64 with a [custom GCC toolchain](https://github.com/rvagg/rpi-newer-crosstools)[^7] |
| linux-ppc64le | RHEL 8 with gcc-toolset-12[^6] |
Expand Down Expand Up @@ -540,6 +542,8 @@ make test-only

#### Speeding up frequent rebuilds when developing

##### ccache

Tips: The `ccache` utility is widely used and should generally work fine.
If you encounter any difficulties, consider disabling `mold` as a
troubleshooting step.
Expand Down Expand Up @@ -575,17 +579,26 @@ export CXX="ccache c++" # add to ~/.zshrc or other shell config file

On Windows:

Tips: follow <https://github.com/ccache/ccache/wiki/MS-Visual-Studio>, and you
should notice that obj file will be bigger the normal one.
Follow <https://github.com/ccache/ccache/wiki/MS-Visual-Studio>, and you
should notice that obj file will be bigger than the normal one.

First, install ccache, assume ccache install to c:\ccache, copy
c:\ccache\ccache.exe to c:\ccache\cl.exe with this command
First, install ccache. Assuming the installation of ccache is in `c:\ccache`
(where you can find `ccache.exe`), copy `c:\ccache\ccache.exe` to `c:\ccache\cl.exe`
with this command.

```powershell
cp c:\ccache\ccache.exe c:\ccache\cl.exe
```

When building Node.js provide a path to your ccache via the option
With newer version of Visual Studio, it may need the copy to be `clang-cl.exe`
instead. If the output of `vcbuild.bat` suggestion missing `clang-cl.exe`, copy
it differently:

```powershell
cp c:\ccache\ccache.exe c:\ccache\clang-cl.exe
```

When building Node.js, provide a path to your ccache via the option:

```powershell
.\vcbuild.bat ccache c:\ccache\
Expand All @@ -594,6 +607,14 @@ When building Node.js provide a path to your ccache via the option
This will allow for near-instantaneous rebuilds when switching branches back
and forth that were built with cache.

To use it with ClangCL, run this instead:

```powershell
.\vcbuild.bat clang-cl ccache c:\ccache\
```

##### Loading JS files from disk instead of embedding

When modifying only the JS layer in `lib`, it is possible to externally load it
without modifying the executable:

Expand Down Expand Up @@ -678,14 +699,19 @@ Optional requirements for compiling for Windows on ARM (ARM64):
* Visual C++ ATL for ARM64
* Windows 10 SDK 10.0.17763.0 or newer

Optional requirements for compiling with ClangCL:
Optional requirements for compiling with ClangCL (search for `clang` in Visual Studio
Installer's "individual component" tab):

* Visual Studio optional components
* Visual Studio individual components
* C++ Clang Compiler for Windows
* MSBuild support for LLVM toolset

NOTE: Currently we only support compiling with Clang that comes from Visual Studio.

When building with ClangCL, if the output from `vcbuild.bat` shows that the components are not installed
even when the Visual Studio Installer shows that they are installed, try removing the components
first and then reinstalling them again.

##### Option 2: Automated install with WinGet

[WinGet configuration files](https://github.com/nodejs/node/tree/main/.configurations)
Expand All @@ -702,7 +728,7 @@ easily. These files will install the following
To install Node.js prerequisites from Powershell Terminal:

```powershell
winget configure .\configurations\configuration.dsc.yaml
winget configure .\.configurations\configuration.dsc.yaml
```

Alternatively, you can use [Dev Home](https://learn.microsoft.com/en-us/windows/dev-home/)
Expand Down
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,8 @@ release.
</tr>
<tr>
<td valign="top">
<b><a href="doc/changelogs/CHANGELOG_V23.md#23.8.0">23.8.0</a></b><br/>
<b><a href="doc/changelogs/CHANGELOG_V23.md#23.9.0">23.9.0</a></b><br/>
<a href="doc/changelogs/CHANGELOG_V23.md#23.8.0">23.8.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V23.md#23.7.0">23.7.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V23.md#23.6.1">23.6.1</a><br/>
<a href="doc/changelogs/CHANGELOG_V23.md#23.6.0">23.6.0</a><br/>
Expand Down
Loading
Loading