Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: move instead of copy shared pointer in node_blob #57120

Merged
merged 1 commit into from
Feb 20, 2025
Merged

src: move instead of copy shared pointer in node_blob #57120

merged 1 commit into from
Feb 20, 2025

Conversation

targos
Copy link
Member

@targos targos commented Feb 18, 2025

Resolves a new warning reported by Coverity.

@targos
src: move instead of copy shared pointer in node_blob
b43c59d 
Resolves a new warning reported by Coverity.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Feb 18, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 18, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.06%. Comparing base (6fe0723) to head (b43c59d).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
src/node_blob.cc 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #57120      +/-   ##
==========================================
- Coverage   89.06%   89.06%   -0.01%     
==========================================
  Files         665      665              
  Lines      193305   193305              
  Branches    37259    37254       -5     
==========================================
- Hits       172159   172158       -1     
  Misses      13829    13829              
- Partials     7317     7318       +1
Files with missing lines Coverage Δ
src/node_blob.cc 75.48% <50.00%> (ø)

... and 18 files with indirect coverage changes

@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 18, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 18, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65300/

@jasnell jasnell added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 18, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 20, 2025
@nodejs-github-bot nodejs-github-bot merged commit 06d5701 into nodejs:main Feb 20, 2025
70 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 06d5701

@targos targos deleted the blob-shared-ptr branch February 20, 2025 12:34
acidiney pushed a commit to acidiney/node that referenced this pull request Feb 23, 2025
@targos @acidiney
src: move instead of copy shared pointer in node_blob
33c5555 
Resolves a new warning reported by Coverity.

PR-URL: nodejs#57120
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
targos added a commit that referenced this pull request Feb 24, 2025
@targos
src: move instead of copy shared pointer in node_blob
0f6895f 
Resolves a new warning reported by Coverity.

PR-URL: #57120
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@github-actions github-actions bot mentioned this pull request Feb 25, 2025
Merged
targos added a commit that referenced this pull request Feb 25, 2025
@targos
src: move instead of copy shared pointer in node_blob
7dd326e 
Resolves a new warning reported by Coverity.

PR-URL: #57120
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@anonrig anonrig anonrig approved these changes

@cjihrig cjihrig cjihrig approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@targos @nodejs-github-bot @jasnell @anonrig @cjihrig @marco-ippolito