Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc fix web.libera.chat link in pull-requests.md #57076

Merged
merged 1 commit into from
Feb 23, 2025

Conversation

SamB
Copy link
Contributor

@SamB SamB commented Feb 15, 2025

The old link wasn't prefilling the channel name for me, and this is the format suggested in the docs: https://libera.chat/guides/webchat#kiwiirc

It works, too!

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 15, 2025
@SamB
Copy link
Contributor Author

SamB commented Feb 15, 2025

Sorry about not having read the commit message rules before committing.

Yes, even though they're in the same file.

@lpinca
Copy link
Member

lpinca commented Feb 15, 2025

@SamB you can amend the commit message and force push to your branch.

The old link wasn't prefilling the channel name for me,
and this is the format suggested in the docs:<https://libera.chat/guides/webchat#kiwiirc>

It works, too!
@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 23, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 23, 2025
@nodejs-github-bot nodejs-github-bot merged commit 4466e07 into nodejs:main Feb 23, 2025
17 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 4466e07

acidiney pushed a commit to acidiney/node that referenced this pull request Feb 23, 2025
The old link wasn't prefilling the channel name for me,
and this is the format suggested in the docs:<https://libera.chat/guides/webchat#kiwiirc>

It works, too!

PR-URL: nodejs#57076
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Feb 24, 2025
The old link wasn't prefilling the channel name for me,
and this is the format suggested in the docs:<https://libera.chat/guides/webchat#kiwiirc>

It works, too!

PR-URL: #57076
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Feb 25, 2025
The old link wasn't prefilling the channel name for me,
and this is the format suggested in the docs:<https://libera.chat/guides/webchat#kiwiirc>

It works, too!

PR-URL: #57076
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants