test_runner: print formatted errors on summary

[pmarchini]

Following this discussion: #56662 (comment)

This PR should address #56902

[nodejs-github-bot]

Review requested:

• @nodejs/test_runner

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.18%. Comparing base (2bd5694) to head (666cb91).
Report is 65 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #56911      +/-   ##
==========================================
+ Coverage   89.16%   89.18%   +0.02%     
==========================================
  Files         665      665              
  Lines      192602   192555      -47     
  Branches    37050    37050              
==========================================
  Hits       171732   171732              
+ Misses      13678    13632      -46     
+ Partials     7192     7191       -1     

Files with missing lines	Coverage Δ
lib/internal/test_runner/reporter/spec.js	96.58% <100.00%> (+0.39%)	⬆️

... and 53 files with indirect coverage changes

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/65029/ 💛

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/56911
✔  Done loading data for nodejs/node/pull/56911
----------------------------------- PR info ------------------------------------
Title      test_runner: print formatted errors on summary (#56911)
Author     Pietro Marchini <[email protected]> (@pmarchini)
Branch     pmarchini:issue/56902 -> nodejs:main
Labels     author ready, needs-ci, dont-land-on-v18.x, test_runner, dont-land-on-v20.x
Commits    2
 - test_runner: print formatted errors on summary
 - test_runner: avoid unnecessary variable declaration
Committers 1
 - Pietro Marchini <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/56911
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/56911
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 04 Feb 2025 09:37:33 GMT
   ✔  Approvals: 3
   ✔  - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/56911#pullrequestreview-2596108820
   ✔  - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/56911#pullrequestreview-2604322740
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/56911#pullrequestreview-2604324168
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2025-02-06T11:18:17Z: https://ci.nodejs.org/job/node-test-pull-request/65029/
- Querying data for job/node-test-pull-request/65029/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 56911
From https://github.com/nodejs/node
 * branch                  refs/pull/56911/merge -> FETCH_HEAD
✔  Fetched commits as d1f8ccb10dab..666cb91c6964
--------------------------------------------------------------------------------
[main f0416a0650] test_runner: print formatted errors on summary
 Author: Pietro Marchini <[email protected]>
 Date: Tue Feb 4 13:50:52 2025 +0100
 4 files changed, 112 insertions(+), 19 deletions(-)
 create mode 100644 test/fixtures/test-runner/output/test-runner-watch-spec.mjs
 create mode 100644 test/fixtures/test-runner/output/test-runner-watch-spec.snapshot
[main 3557f27e18] test_runner: avoid unnecessary variable declaration
 Author: Pietro Marchini <[email protected]>
 Date: Tue Feb 4 21:51:50 2025 +0100
 1 file changed, 1 insertion(+), 2 deletions(-)
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
Rebasing (2/4)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
test_runner: print formatted errors on summary
PR-URL: #56911

Reviewed-By: Colin Ihrig <[email protected]>

Reviewed-By: Chemi Atlow <[email protected]>

Reviewed-By: James M Snell <[email protected]>
[detached HEAD ca1afd2758] test_runner: print formatted errors on summary

Author: Pietro Marchini <[email protected]>

Date: Tue Feb 4 13:50:52 2025 +0100

4 files changed, 112 insertions(+), 19 deletions(-)

create mode 100644 test/fixtures/test-runner/output/test-runner-watch-spec.mjs

create mode 100644 test/fixtures/test-runner/output/test-runner-watch-spec.snapshot

Rebasing (3/4)

Rebasing (4/4)

Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

test_runner: avoid unnecessary variable declaration
PR-URL: #56911

Reviewed-By: Colin Ihrig <[email protected]>

Reviewed-By: Chemi Atlow <[email protected]>

Reviewed-By: James M Snell <[email protected]>
[detached HEAD e71dd77b5e] test_runner: avoid unnecessary variable declaration

Author: Pietro Marchini <[email protected]>

Date: Tue Feb 4 21:51:50 2025 +0100

1 file changed, 1 insertion(+), 2 deletions(-)

Successfully rebased and updated refs/heads/main.
ℹ  Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/13228205767

[nodejs-github-bot]

Landed in a2aa6ca