Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(externals): skip resolving virtual ids start with \0 #2321

Merged
merged 2 commits into from
Mar 27, 2024
Merged

fix(externals): skip resolving virtual ids start with \0 #2321

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
079bfd6
fix(externals): skip resolving virtual ids
pi0 Mar 27, 2024
e6cf547
add fix for isExplicitInline too
pi0 Mar 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/rollup/plugins/externals.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,9 @@ export function externals(opts: NodeExternalsOptions): Plugin {

const _resolveCache = new Map();
const _resolve = async (id: string): Promise<string> => {
if (id.startsWith("\0")) {
return id;
}
let resolved = _resolveCache.get(id);
if (resolved) {
return resolved;
Expand All @@ -63,6 +66,9 @@ export function externals(opts: NodeExternalsOptions): Plugin {

// Utility to check explicit inlines
const isExplicitInline = (id: string, importer: string) => {
if (id.startsWith("\0")) {
return true;
}
const inlineMatch = inlineMatchers.find((m) => m(id, importer));
const externalMatch = externalMatchers.find((m) => m(id, importer));
if (
Expand Down