Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove library module name in vue wrapper build #691

Merged
merged 1 commit into from
Jul 8, 2021

Conversation

jwlee1108
Copy link
Contributor

@jwlee1108 jwlee1108 commented Jul 6, 2021

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description

This PR is to fix vue-chart build script. When @toast-ui/vue-chart is imported in the version before the change, the chart is contained in an toastui object.

  • When we write code below
    import tui from '@toast-ui/vue-chart;
    console.log(tui);
    image

Related to #686


Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

Copy link
Contributor

@dongsik-yoo dongsik-yoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료합니다. 수고하셨습니다.

Copy link

@lja1018 lja1018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰완료합니다.

Copy link

@adhrinae adhrinae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료합니다.

Copy link

@js87zz js87zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

늦었지만 리뷰 완료합니다~!

@jwlee1108 jwlee1108 merged commit 78c7a38 into main Jul 8, 2021
@jwlee1108 jwlee1108 deleted the fix/vue-build-script branch July 8, 2021 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants