Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rerun failed tests with rspec-retry #163

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Rerun failed tests with rspec-retry #163

wants to merge 1 commit into from

Conversation

vankiru
Copy link
Collaborator

@vankiru vankiru commented Feb 20, 2025

No description provided.

@vankiru vankiru marked this pull request as ready for review February 20, 2025 15:49
@vankiru vankiru changed the title Rerun tests if they fail Rerun failed tests with rspec-retry Feb 20, 2025
wallyqs
wallyqs approved these changes Feb 20, 2025
View reviewed changes
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wallyqs
Copy link
Member

wallyqs commented Feb 20, 2025

notice that CI still failed on a flake? Maybe something else needed to enable?

 1) Client - Drain should gracefully drain a connection
     Failure/Error: expect(wait_reqs.wait_for(2)).to eql(:ok)
     
       expected: :ok
            got: nil
     
       (compared using eql?)
     # ./spec/client_drain_spec.rb:98:in `block (2 levels) in <top (required)>'
     # ./vendor/bundle/ruby/3.3.0/gems/rspec-retry-0.6.2/lib/rspec/retry.rb:124:in `block in run'
     # ./vendor/bundle/ruby/3.3.0/gems/rspec-retry-0.6.2/lib/rspec/retry.rb:110:in `run'
     # ./vendor/bundle/ruby/3.3.0/gems/rspec-retry-0.6.2/lib/rspec_ext/rspec_ext.rb:12:in `run_with_retry'
     # ./vendor/bundle/ruby/3.3.0/gems/rspec-retry-0.6.2/lib/rspec/retry.rb:37:in `block (2 levels) in setup'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wallyqs wallyqs wallyqs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vankiru @wallyqs