7936 add discrete event visualization refactor #8004
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Allow highlights and locking highlight points for plots in compact mode, but still disallow pan and zoom. * Remove unnecessary watch on cursor guides and grid lines * Test for cursor guides in compact mode
* migrate from actions/upload-artifact: v3 to v4. https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md * Add names for artifacts and allow overwriting them
…#7956) * Ensure that the mode set when independent time conductor is enabled/disabled is propagated correctly. Also ensure that global time conductor changes are not picked up by the independent time conductor when the user has enabled it at least once before * Use structuredClone instead of deep copy * Add e2e test * Assert that you're in fixed mode after sync time conductor * Comment explaining new time context test * Change test to be a little less complicated * Fix linting errors
… now is out of bounds (#7993) * Account for right y-axes when calculating now line position. Don't show the now line if it's out of bounds of the time axis * Add test for now marker in realtime and out of bounds modes
…riority for eventtimelineviewprovider to HIGH. Also add a condition to the eventtimelineview to reject objects that have imagery (this is to promote the imagerytimestripview to handle those objets)
1) reduce call to instance method 2) Use existing event line bus functionality 3) move non reactive properties to the created lifecycle hook
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 7936-add-discrete-event-visualization #8004 +/- ##
=========================================================================
- Coverage 57.18% 57.04% -0.15%
=========================================================================
Files 686 686
Lines 27825 27776 -49
Branches 2741 2735 -6
=========================================================================
- Hits 15913 15846 -67
- Misses 11569 11585 +16
- Partials 343 345 +2
... and 10 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
…d-discrete-event-visualization-refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
Describe your changes:
All Submissions:
Author Checklist
type:label? Note: this is not necessarily the same as the original issue.Reviewer Checklist