[Time Strip] allow user to adjust width and height of swimlanes #8003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- timeline-holder now set to 100% height. - c-swimlane now space-fills available vertical space, and provides overflow scroll.
- resize is not yet persisted
- WIP! - Moved many CSS defs from flexible-layout.scss into new mixin `resizeHandleStyle`. - Fixed bad `drap-orientation` arg in TimelineViewLayout.vue. - Styling for resize handles in Time Strip view.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 7936-add-discrete-event-visualization #8003 +/- ##
=========================================================================
- Coverage 57.03% 49.66% -7.37%
=========================================================================
Files 686 690 +4
Lines 27784 27906 +122
Branches 2735 2737 +2
=========================================================================
- Hits 15846 13860 -1986
- Misses 11593 13702 +2109
+ Partials 345 344 -1
*This pull request uses carry forward flags. Click here to find out more.
... and 203 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
- Repair broken Plan/Gantt view when not in Time Strip.
- Column resizing now shows the horizontal resize handle on the Time axis swimlane only. Handle now uses `:height` from the extended overlay lines to extend across all swimlanes. - TODO: fix regressions in Plan/Gantt view affecting swimlane height and overflow handling.
…adjustable-swimlane-size
…adjustable-swimlane-size
…adjustable-swimlane-size
| import { inject } from 'vue'; | ||
| import { useDragResizer } from 'utils/vue/useDragResizer.js'; | ||
| import { useFlexContainers } from 'utils/vue/useFlexContainers.js'; | ||
| import { inject, provide, ref } from 'vue'; |
There was a problem hiding this comment.
external packages have first declaration/import order
- Reduced opacity of extended event lines and the Marcus-Baines line to not obfuscate telemetry and other data displayed in the Time Strip. - Removed commented CSS code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7957
Describe your changes:
custom width adjustment inside a nested time stripfix handles for plan labels nested in time strips resizing allFixes
All Submissions:
Author Checklist
type:label? Note: this is not necessarily the same as the original issue.Reviewer Checklist