-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discrete Event Visualization in Timeline #7967
Open
scottbell
wants to merge
76
commits into
master
Choose a base branch
from
7936-add-discrete-event-visualization
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
76 commits
Select commit
Hold shift + click to select a range
3159de0
initial structure
scottbell 680b095
more scaffolding
scottbell 7b22cf3
going to try with YAMCS data
scottbell 7af3996
fix events not being removed
scottbell 944634d
adding inspector
scottbell 55bed6a
Merge remote-tracking branch 'origin/master' into 7936-add-discrete-e…
scottbell 2776cc8
inspector works
scottbell 5b006b6
inspector and colors work
scottbell 8b5e2f4
remove undefined
scottbell 3b236cc
pass event bus
scottbell 0db301d
add facility to send action to mounted component regarding extending …
scottbell e9f120a
button works
scottbell d046ad1
extended events
scottbell 052129b
ensure colored lines work
scottbell 6f26add
works per swimlane now
scottbell aaec052
add title
scottbell 96d8870
watch for left offset changes
scottbell 3829295
Closes #7960
charlesh88 3d3f093
Closes #7960
charlesh88 64bd625
remove debugging code and extraneous classes
scottbell 781d834
add hovered effect for extended lines
scottbell d97f7c3
resolve conflicts
scottbell cda7cc9
fix extended lines
scottbell d048af1
add tooltip
scottbell 62b4975
add selection class
scottbell 20247bb
only add left margin to container
scottbell 20426fe
add tooltip class and only offset swimlane
scottbell 6bda108
Closes #7936
charlesh88 aaa2e43
Closes #7936
charlesh88 2ba6bc9
ensure metadata exists on events
scottbell 3af9083
add a random severity
scottbell 36d3197
bump priority for our timeline view
scottbell 72ff0bc
start e2e testing
scottbell f4ec532
add tests
scottbell 49a106b
Closes #7936
charlesh88 cba7c7f
remove is selected, add hover event for extended liens
scottbell 2ae1fe1
resolve conflicts
scottbell b865d8c
Closes #7936
charlesh88 27af030
Mods to Event Generator and limit provider
charlesh88 099153b
Closes #7936
charlesh88 546714b
Closes #7936
charlesh88 51d9654
fix selection issue
scottbell 68fc317
Merge branch '7936-add-discrete-event-visualization' of github.com:na…
scottbell 531ef3e
good job tests
scottbell 638b03c
spelling
scottbell 601fc33
trigger off selection for extended line hilight
scottbell 8c72e4a
Closes #7936
charlesh88 65b1f02
Closes #7936
charlesh88 3c24205
Merge remote-tracking branch 'origin/7936-add-discrete-event-visualiz…
charlesh88 5312458
Closes #7936
charlesh88 bb4fea7
Closes #7936
charlesh88 5b28086
Closes #7936
charlesh88 9522040
Closes #7936
charlesh88 6cafa7a
Closes #7936
charlesh88 cfa2129
Closes #7936
charlesh88 e6cb940
Closes #7936
charlesh88 f163034
Closes #7936
charlesh88 0933d27
Closes #7936
charlesh88 15b674f
Closes #7936
charlesh88 0e940b2
lint and simplify playwright locator
scottbell 32a0e15
handle case where we only have events in timeline
scottbell 9e68514
Removed commented out code
shefalijoshi 1ced12d
Remove the priority for imagerytimestripviewprovider and reduce the p…
shefalijoshi 3ad64f0
Refactor code to
shefalijoshi aa5fa46
Use the tooltips mixin
shefalijoshi 74a5d7e
Merge branch 'master' of https://github.com/nasa/openmct into 7936-ad…
shefalijoshi 157bde8
Fix linting issues
shefalijoshi 8be969f
Increase priority of event timeline view provider
shefalijoshi 14a5c47
Increase the priority of EventtimelineView
shefalijoshi 88b4331
Handle right offset alignment for event timeline view
shefalijoshi b171f82
Ensure now marker shows up correctly even when there are no plots to …
shefalijoshi af6f327
remove extraneous class
scottbell bbae9c6
use this.el instead of hardcoded layout ref
scottbell 55d15ca
add documentation as to why we need the label hint for EventTimelineView
scottbell 8545dde
remove eventemitter and use native custom events
scottbell 2e35212
Decode object path
akhenry File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I vaguely recall
.parentElement
not working in some specific cases for planView, but maybe that's not an issue here. I'll test.