[Gauge Plugin] Fix Missing Object handling #7923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7923 +/- ##
==========================================
- Coverage 57.66% 57.43% -0.24%
==========================================
Files 677 677
Lines 27373 27375 +2
Branches 2689 2690 +1
==========================================
- Hits 15786 15724 -62
- Misses 11248 11310 +62
- Partials 339 341 +2
... and 10 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
…enmct into gauge-missing-object-fix mergin
|
Should we use telemetry collection here for gauges? |
Yes, but not for this one! |
jvigliotta
requested review from
charlesh88 and
davetsay
and removed request for
charlesh88
akhenry
pushed a commit
that referenced
this pull request
Dec 4, 2024
* checking if the metadata exists before acting on it * added a test to catch missing object errors in gauges * remove waitForTimeout and add in check for time conductor successful start offset update * hardening the test by checking for the time before the time change * add "pageerror" to cspell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7908
Describe your changes:
Don't make requests if there's no metadata.
All Submissions:
Author Checklist
type:label? Note: this is not necessarily the same as the original issue.Reviewer Checklist