Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gantt chart swimlane order #7895

Merged
merged 3 commits into from
Oct 17, 2024
Merged

Fix gantt chart swimlane order #7895

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
12297a5
Use the planObject to get ordered swimlane names
shefalijoshi Oct 16, 2024
a1e8920
If there is no plan object, don't try to render the chart
shefalijoshi Oct 16, 2024
b9eef3b
Merge branch 'master' into fix-gantt-chart-swimlane-order
jvigliotta Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/plugins/plan/components/PlanView.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,8 +243,8 @@
if (this.planObject) {
this.showReplacePlanDialog(domainObject);
} else {
this.swimlaneVisibility = this.configuration.swimlaneVisibility;
this.setupPlan(domainObject);
this.swimlaneVisibility = this.configuration.swimlaneVisibility;

Check warning on line 247 in src/plugins/plan/components/PlanView.vue

View check run for this annotation

Codecov / codecov/patch

src/plugins/plan/components/PlanView.vue#L247 

Added line #L247 was not covered by tests
}
},
handleConfigurationChange(newConfiguration) {
Expand Down Expand Up @@ -423,7 +423,10 @@
return currentRow || SWIMLANE_PADDING;
},
generateActivities() {
const groupNames = getValidatedGroups(this.domainObject, this.planData);
if (!this.planObject) {
return;

Check warning on line 427 in src/plugins/plan/components/PlanView.vue

View check run for this annotation

Codecov / codecov/patch

src/plugins/plan/components/PlanView.vue#L427 

Added line #L427 was not covered by tests
}
const groupNames = getValidatedGroups(this.planObject, this.planData);

if (!groupNames.length) {
return;
Expand Down
Loading