test(e2e): stabilize flaky imagery tests #7765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ozyx
force-pushed
the
fix-unstable-tests-in-imagery
branch
from
6f103d1 to
d1da4ff
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7765 +/- ##
==========================================
- Coverage 57.07% 56.81% -0.26%
==========================================
Files 674 674
Lines 27273 27278 +5
Branches 2665 2668 +3
==========================================
- Hits 15566 15499 -67
- Misses 11367 11439 +72
Partials 340 340
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
unlikelyzero
reviewed
Jul 1, 2024
unlikelyzero
reviewed
Jul 1, 2024
unlikelyzero
reviewed
Jul 1, 2024
ozyx
force-pushed
the
fix-unstable-tests-in-imagery
branch
from
09ecf3c to
f212823
Compare
e2e/tests/functional/plugins/imagery/exampleImagery.e2e.spec.js
Outdated
Show resolved
Hide resolved
e2e/tests/functional/plugins/imagery/exampleImagery.e2e.spec.js
Outdated
Show resolved
Hide resolved
e2e/tests/functional/plugins/imagery/exampleImagery.e2e.spec.js
Outdated
Show resolved
Hide resolved
e2e/tests/functional/plugins/imagery/exampleImagery.e2e.spec.js
Outdated
Show resolved
Hide resolved
unlikelyzero
approved these changes
Jul 16, 2024
ozyx
force-pushed
the
fix-unstable-tests-in-imagery
branch
from
f212823 to
0c90016
Compare
e2e/tests/functional/plugins/imagery/exampleImagery.e2e.spec.js
Outdated
Show resolved
Hide resolved
ozyx
force-pushed
the
fix-unstable-tests-in-imagery
branch
from
05f861a to
f63b97b
Compare
- add class for `is-panning` and wait on it in the tests - use mock clock to fast forward in time - add a11y for thumbnails - increase mouse yDelta for more consistent behavior - some locator improvements but it's still fairly atrocious
unlikelyzero
approved these changes
Jul 24, 2024
| // We mock the clock so that we don't need to wait for time driven events | ||
| // to verify functionality. | ||
| await page.clock.setSystemTime(MISSION_TIME); | ||
| await page.clock.resume(); |
ozyx
commented
Jul 24, 2024
| @@ -39,7 +39,7 @@ export default merge(common, { | |||
| return shouldWrite; | |||
| } | |||
| }, | |||
| watchFiles: ['**/*.css'], | |||
| watchFiles: ['src/**/*.css', 'example/**/*.css'], | |||
There was a problem hiding this comment.
Webpack was rebuilding when playwright test reports were being generated and updated so let's be explicit
ozyx
commented
Oct 2, 2024
Comment on lines
+93
to
+101
| inject: ['openmct', 'domainObject', 'resetImage', 'handlePanZoomUpdate'], | ||
| provide() { | ||
| return { | ||
| resetImage: this.resetImage, | ||
| zoomIn: this.zoomIn, | ||
| zoomOut: this.zoomOut, | ||
| toggleZoomLock: this.toggleZoomLock | ||
| }; | ||
| }, |
There was a problem hiding this comment.
need to regression test this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7769
Note: merge #7762 first
Describe your changes:
All Submissions:
Author Checklist
type:label? Note: this is not necessarily the same as the original issue.Reviewer Checklist