-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If display bounds are out of sync with time conductor, don't purge data out of bounds #7732
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7732 +/- ##
=======================================
Coverage 56.66% 56.66%
=======================================
Files 673 673
Lines 27177 27177
Branches 2636 2636
=======================================
Hits 15399 15399
Misses 11447 11447
Partials 331 331
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Tests, please. Nothing should be pushed any more without tests. |
Create new test spec for plot controls
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor e2e test changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests are failing
…is used on the same page more than once.
Tests are passing, now there's a simple spelling mistake causing linting to fail :) |
But hey, the spellchecker caught something, that's cool! |
…openmct into fix-plot-data-purge-paused
Closes #6460
Describe your changes:
In addition to panning and zooming, also check if we're paused to not purge data out of bounds.
All Submissions:
Author Checklist
type:
label? Note: this is not necessarily the same as the original issue.Reviewer Checklist