-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Telemetry Tables] Make sure tables auto scroll correctly on first load #7720
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7720 +/- ##
==========================================
+ Coverage 56.12% 56.59% +0.46%
==========================================
Files 673 673
Lines 27181 27182 +1
Branches 2635 2635
==========================================
+ Hits 15256 15383 +127
+ Misses 11595 11468 -127
- Partials 330 331 +1
... and 18 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Smoke tested and works perfectly. One request is to label your test as sort descending and add a test for sort ascending.
e2e/tests/functional/plugins/telemetryTable/telemetryTable.e2e.spec.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a suggestion on how to avoid using hard waits in the e2e
e2e/tests/functional/plugins/telemetryTable/telemetryTable.e2e.spec.js
Outdated
Show resolved
Hide resolved
e2e/tests/functional/plugins/telemetryTable/telemetryTable.e2e.spec.js
Outdated
Show resolved
Hide resolved
e2e/tests/functional/plugins/telemetryTable/telemetryTable.e2e.spec.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #7669
Describe your changes:
Added an after load action to scroll to the top after a table is first visited. This handles cases where historical telemetry can come in and affect the initial sticky scroll.
All Submissions:
Author Checklist
type:
label? Note: this is not necessarily the same as the original issue.Reviewer Checklist