Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove all usage of deprecated Time API methods #7688

Merged
merged 4 commits into from
Apr 16, 2024
Merged

chore: remove all usage of deprecated Time API methods #7688

merged 4 commits into from
Apr 16, 2024

Conversation

ozyx
Copy link
Contributor

@ozyx ozyx commented Apr 12, 2024

Closes #7687

Describe your changes:

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@ozyx ozyx changed the title mct7687 chore: remove all usage of deprecated Time API methods Apr 12, 2024
@ozyx ozyx added this to the Target:4.0.0 milestone Apr 12, 2024
@ozyx ozyx added the type:maintenance tests, chores, or project maintenance label Apr 12, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2024

Codecov Report

Attention: Patch coverage is 58.46154% with 27 lines in your changes are missing coverage. Please review.

Project coverage is 56.33%. Comparing base (e91aba2) to head (386efae).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7688      +/-   ##
==========================================
+ Coverage   56.28%   56.33%   +0.05%     
==========================================
  Files         672      672              
  Lines       27135    27135              
  Branches     2634     2634              
==========================================
+ Hits        15273    15287      +14     
+ Misses      11534    11520      -14     
  Partials      328      328              
Flag Coverage Δ
e2e-full 23.63% <11.76%> (ø)
e2e-stable 60.24% <35.29%> (-0.06%) ⬇️
unit 49.13% <56.92%> (+0.03%) ⬆️
Files Coverage Δ
src/api/time/GlobalTimeContext.js 92.85% <ø> (ø)
src/api/time/TimeAPI.js 90.90% <ø> (ø)
src/api/time/TimeContext.js 90.47% <ø> (+8.92%) ⬆️
src/plugins/LADTable/components/LadRow.vue 55.67% <100.00%> (ø)
...ettingsSynchronizer/URLTimeSettingsSynchronizer.js 96.96% <100.00%> (ø)
src/plugins/condition/Condition.js 75.00% <ø> (ø)
src/plugins/condition/ConditionManager.js 75.00% <ø> (ø)
src/plugins/condition/StyleRuleManager.js 74.44% <100.00%> (ø)
src/plugins/gauge/components/GaugeComponent.vue 63.06% <100.00%> (ø)
src/plugins/imagery/mixins/imageryData.js 96.55% <100.00%> (ø)
... and 27 more

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e91aba2...386efae. Read the comment docs.

@unlikelyzero unlikelyzero added the notable_change A change which should be noted in the changelog label Apr 14, 2024
@ozyx
Copy link
Contributor Author

ozyx commented Apr 14, 2024

I can add some quick unit tests to cover the changes @unlikelyzero

@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Apr 16, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Apr 16, 2024
@ozyx ozyx enabled auto-merge (squash) April 16, 2024 21:01
@ozyx ozyx merged commit 6c5b925 into master Apr 16, 2024
17 of 19 checks passed
@ozyx ozyx deleted the mct7687 branch April 16, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notable_change A change which should be noted in the changelog type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove all usage of deprecated Time API methods
3 participants