-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Darkmatter] Create new darkmatter theme #7682
Merged
Merged
Changes from 44 commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
bc4ad98
initial theme plugin setup, changes to layout frames
rukmini-bose 335a29c
update visual tests
unlikelyzero bb11d6d
Changes to gauge, layout borders, and background
rukmini-bose df587ca
Make background image a DIY theme variable. Fixes made to gauges. Del…
rukmini-bose 89d33ef
More changes to overall background colors. Added glass layer effect t…
rukmini-bose ac07a88
changes to menu
rukmini-bose 11762bd
Fix to make theme easy to run
rukmini-bose 081da4c
Fix tab colors and add glass background to menus
rukmini-bose f35e721
make highlightd corners longer
rukmini-bose d1bc48c
Initial changes to font styles
rukmini-bose 4abdffc
Add temporary numeric font style. Test numeric font in gauges.
rukmini-bose 9e9857e
Initial changes to alphanumerics in layouts
rukmini-bose 270e3e7
Updated variables
rukmini-bose 39cf1ca
update plugin.js file
rukmini-bose 7a1e8ef
Fix highlighted corners on frames such that it uses outermost frame
rukmini-bose cbe857f
renaming theme plugin and rename branch
rukmini-bose 3a917da
fix button colors to be more readable
rukmini-bose 6913ea4
change background image
rukmini-bose d52470b
Merge branch 'master' into darkmatter-theme
rukmini-bose fcbff2d
Fix bad merges from other theme files. Fix gauge and alphanumerics su…
rukmini-bose 83bba7d
more fixes
rukmini-bose 0b6de22
Fix where mixin is used such that when an object's frame is hidden, h…
rukmini-bose 6a8328f
remove blur from meter gauges
rukmini-bose 524726f
Merge branch 'master' into darkmatter-theme
rukmini-bose fe4d3b0
Add comment about this theme being in beta mode
rukmini-bose 38cd0ba
Delete draft .scss file that is no longer needed
rukmini-bose 09b7b2c
Fix major accessibility issues
rukmini-bose c2275b6
Fix PR review comments
rukmini-bose bce4638
✨ fix: Correct import file name for DarkMatter theme.
ozyx 8cf6412
Fix other theme code that was failing e2e tests
rukmini-bose 696ebfc
Revert index.html
rukmini-bose 66f498f
Fix linting error
rukmini-bose 5aa76e4
Fix for failing percy test regarding padding
rukmini-bose 2d0fab5
Fix for failing percy test regarding padding part 2
rukmini-bose 22124df
Fix for failing percy test regarding padding part 3
rukmini-bose cc1f575
Remove mixin that may be causing percy issue
rukmini-bose bd00800
Another fix to resolve percy issue
rukmini-bose 32edd30
Add back some code that was deleted during debugging, and create new …
rukmini-bose 57238ff
Fix gradient clipping in inspector
rukmini-bose 3357d40
Restructure all constants-.scss files
rukmini-bose 039e1ce
Change bg image to be square and NASA official picture
rukmini-bose 43d21f0
Final fixes to darkmatter variable layouts
rukmini-bose 915f00a
Merge branch 'master' into darkmatter-theme
rukmini-bose 830ec23
Address PR comments
rukmini-bose 4bc0cea
Change darkmatter to darkmatterTheme
rukmini-bose File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,6 +18,7 @@ | |
} | ||
|
||
&__value { | ||
@include telemetryView(); | ||
@include isLimit(); | ||
} | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
/***************************************************************************** | ||
* Open MCT, Copyright (c) 2014-2024, United States Government | ||
* as represented by the Administrator of the National Aeronautics and Space | ||
* Administration. All rights reserved. | ||
* | ||
* Open MCT is licensed under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* http://www.apache.org/licenses/LICENSE-2.0. | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
* License for the specific language governing permissions and limitations | ||
* under the License. | ||
* | ||
* Open MCT includes source code licensed under additional open source | ||
* licenses. See the Open Source Licenses file (LICENSES.md) included with | ||
* this source code distribution or the Licensing information page available | ||
* at runtime from the About dialog for additional information. | ||
*****************************************************************************/ | ||
|
||
@import '../../styles/vendor/normalize-min'; | ||
rukmini-bose marked this conversation as resolved.
Show resolved
Hide resolved
|
||
@import '../../styles/constants'; | ||
@import '../../styles/constants-mobile.scss'; | ||
|
||
@import '../../styles/constants-darkmatter'; | ||
|
||
@import '../../styles/mixins'; | ||
@import '../../styles/animations'; | ||
@import '../../styles/about'; | ||
@import '../../styles/glyphs'; | ||
@import '../../styles/global'; | ||
@import '../../styles/status'; | ||
@import '../../styles/limits'; | ||
@import '../../styles/controls'; | ||
@import '../../styles/forms'; | ||
@import '../../styles/table'; | ||
@import '../../styles/legacy'; | ||
@import '../../styles/legacy-plots'; | ||
@import '../../styles/plotly'; | ||
@import '../../styles/legacy-messages'; | ||
|
||
@import '../../styles/vue-styles.scss'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
/***************************************************************************** | ||
* Open MCT, Copyright (c) 2014-2024, United States Government | ||
* as represented by the Administrator of the National Aeronautics and Space | ||
* Administration. All rights reserved. | ||
* | ||
* Open MCT is licensed under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* http://www.apache.org/licenses/LICENSE-2.0. | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
* License for the specific language governing permissions and limitations | ||
* under the License. | ||
* | ||
* Open MCT includes source code licensed under additional open source | ||
* licenses. See the Open Source Licenses file (LICENSES.md) included with | ||
* this source code distribution or the Licensing information page available | ||
* at runtime from the About dialog for additional information. | ||
*****************************************************************************/ | ||
// Note: This darkmatter theme is in Beta and is not yet ready for prime time. It needs some more tweaking. | ||
rukmini-bose marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
import { installTheme } from './installTheme.js'; | ||
|
||
export default function plugin() { | ||
return function install(openmct) { | ||
installTheme(openmct, 'darkmatter'); | ||
}; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to expose this as
DarkMatterTheme
so it's clear what it is. We can't really go back and change the other two plugin names so it will be inconsistent, but it might communicate more effectively what the plugin does. What do you think?