Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#7633): add missing await #7643

Merged
merged 2 commits into from
Mar 26, 2024
Merged

fix(#7633): add missing await #7643

merged 2 commits into from
Mar 26, 2024

Conversation

ozyx
Copy link
Contributor

@ozyx ozyx commented Mar 25, 2024

Closes #7633

Describe your changes:

  • Adds back missing await
  • Adds regression test

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@ozyx ozyx added the type:bug label Mar 25, 2024
@ozyx ozyx added this to the Target:4.0.1 milestone Mar 25, 2024
@ozyx ozyx requested review from scottbell and unlikelyzero March 25, 2024 22:26
@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Mar 25, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Mar 25, 2024
Copy link
Contributor

@scottbell scottbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works great

@scottbell scottbell enabled auto-merge (squash) March 26, 2024 10:14
@scottbell scottbell merged commit 493b31d into master Mar 26, 2024
42 of 45 checks passed
@scottbell scottbell deleted the mct7633 branch March 26, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot remove children from LAD Table while viewing it
3 participants