Handle the case where the pasted data is not an image #7628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -384,7 +384,7 @@ export default { | |||
|
|
|||
| this.manageEmbedLayout(); | |||
| }, | |||
| async addImageFromPaste(event) { | |||
| async addImageOrTextFromPaste(event) { | |||
| const clipboardItems = Array.from( | |||
There was a problem hiding this comment.
check for empty clippboard item?
|
@shefalijoshi e2e test please |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7628 +/- ##
==========================================
- Coverage 56.33% 55.93% -0.41%
==========================================
Files 672 672
Lines 27124 27124
Branches 2632 2632
==========================================
- Hits 15281 15171 -110
- Misses 11515 11624 +109
- Partials 328 329 +1
... and 21 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
akhenry
approved these changes
Apr 4, 2024
akhenry
added a commit
that referenced
this pull request
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes VIPEROMCT-474
Describe your changes:
When pasting text (or text and image together), the
pasteevent handler was adding the image to the entry and saving the entry. The textareablurevent handler never got a chance to get triggered, so the entry's text update would get ignored.Now, when there is any pasting in the text area, we're ensuring that both images and text are updated appropriately.
All Submissions:
Author Checklist
type:label? Note: this is not necessarily the same as the original issue.Reviewer Checklist