-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle empty namespaces in import #7619
Handle empty namespaces in import #7619
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7619 +/- ##
==========================================
- Coverage 56.15% 56.14% -0.01%
==========================================
Files 672 672
Lines 27122 27128 +6
Branches 2635 2635
==========================================
+ Hits 15230 15231 +1
- Misses 11565 11570 +5
Partials 327 327
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
This is pretty tricky to write an e2e test because we need to test with a namespace'd couchdb server, which I don't think we have. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just needs some kind of test
…-in-anything-other-than-the-default-namespace
Tested locally and it looks good. Filed a followup for the test - #7621 |
…other-than-the-default-namespace' of github.com:nasa/openmct into 7617-import-from-json-action-does-not-work-in-anything-other-than-the-default-namespace
Closes #7617
Describe your changes:
When importing a JSON dump that came from a setup without a namespace set, the regex we use in the ImportJsonAction was setting the key to
namespace:key
, instead of properly separating the two. Now we detect corrupted keys, and repair them during the import.All Submissions:
Author Checklist
type:
label? Note: this is not necessarily the same as the original issue.Reviewer Checklist