Upgrade prettier and eslint compatibility libraries to latest #7478
Conversation
- upgrade prettier - upgrade eslint - upgrade eslint-plugin-prettier - upgrade eslint-config-prettier
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7478 +/- ##
=======================================
Coverage 55.50% 55.50%
=======================================
Files 671 671
Lines 26938 26938
Branches 2614 2614
=======================================
+ Hits 14951 14952 +1
+ Misses 11271 11269 -2
- Partials 716 717 +1
*This pull request uses carry forward flags. Click here to find out more. see 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
- The `prettier-eslint` vscode plugin sinc v6.0.0 no longer provides this package so we must install it as a devDependency so that autoformat works.
|
...and we have a new release of vscode-prettier-eslint that works! Huzzah! |
| @@ -0,0 +1,14 @@ | |||
| { | |||
| // See https://go.microsoft.com/fwlink/?LinkId=827846 to learn about workspace recommendations. | |||
There was a problem hiding this comment.
huh. i think it still works but i'll remove it anyway
There was a problem hiding this comment.
It's jsonc actually. Just like tsconfig.json.
There was a problem hiding this comment.
@JounQin hey, thanks!
@unlikelyzero i'm gonna revert this
This reverts commit 942f341.
Describe your changes:
In order to upgrade to prettier 3.x.x, we also need to upgrade the related eslint compatibility libraries (eslint, eslint-plugin-prettier, eslint-config-prettier). This PR does it all in one go, and runs lint:fix which only has one small change.
Also adds
.vscode/extensions.jsonso that vscode can recommend extensions (such as prettier-eslint) for working in our codebaseAll Submissions:
Author Checklist
type:label? Note: this is not necessarily the same as the original issue.Reviewer Checklist