Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): add e2e and visual tests for Mission Status (plus a11y) #7462

Merged
merged 7 commits into from
Feb 6, 2024

Conversation

ozyx
Copy link
Contributor

@ozyx ozyx commented Feb 5, 2024

Closes #7461

Describe your changes:

  • Add e2e and visual test suites for Mission Status
  • Add a11y wherever needed
  • Enable the ExampleUser to set Mission Status so we can test the feature

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Is this a breaking change to be called out in the release notes?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@ozyx ozyx added the type:maintenance tests, chores, or project maintenance label Feb 5, 2024
@ozyx ozyx added this to the Target:4.0.0 milestone Feb 5, 2024
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (eeb8e97) 55.37% compared to head (f060c5e) 52.56%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7462      +/-   ##
==========================================
- Coverage   55.37%   52.56%   -2.81%     
==========================================
  Files         671      671              
  Lines       26930    26938       +8     
  Branches     2614     2614              
==========================================
- Hits        14912    14161     -751     
- Misses      11302    12061     +759     
  Partials      716      716              
Flag Coverage Δ *Carryforward flag
e2e-full 48.92% <ø> (+0.01%) ⬆️ Carriedforward from b5911e1
e2e-stable 38.72% <11.11%> (-20.23%) ⬇️
unit 48.47% <69.23%> (+0.10%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...ns/userIndicator/components/MissionStatusPopup.vue 56.25% <100.00%> (+56.25%) ⬆️
...plugins/userIndicator/components/UserIndicator.vue 27.94% <66.66%> (ø)
example/exampleUser/ExampleUserProvider.js 45.90% <66.66%> (-35.24%) ⬇️

... and 106 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eeb8e97...f060c5e. Read the comment docs.

Copy link
Contributor

@scottbell scottbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice tests!

Copy link
Contributor

@unlikelyzero unlikelyzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure the aria-label isn't necessary as I noted. It would be better to use HTML5

@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Feb 6, 2024
@ozyx ozyx enabled auto-merge (squash) February 6, 2024 19:34
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Feb 6, 2024
@ozyx ozyx merged commit 539b433 into master Feb 6, 2024
21 checks passed
@ozyx ozyx deleted the tests-for-mission-status branch February 6, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add e2e and visual tests for Mission Status
3 participants