-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(e2e): add e2e and visual tests for Mission Status (plus a11y) #7462
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #7462 +/- ##
==========================================
- Coverage 55.37% 52.56% -2.81%
==========================================
Files 671 671
Lines 26930 26938 +8
Branches 2614 2614
==========================================
- Hits 14912 14161 -751
- Misses 11302 12061 +759
Partials 716 716
*This pull request uses carry forward flags. Click here to find out more.
... and 106 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice tests!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure the aria-label isn't necessary as I noted. It would be better to use HTML5
Closes #7461
Describe your changes:
All Submissions:
Author Checklist
type:
label? Note: this is not necessarily the same as the original issue.Reviewer Checklist