Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix actions menu on display layout alphanumerics #7414

Merged

Conversation

scottbell
Copy link
Contributor

@scottbell scottbell commented Jan 25, 2024

Closes #7400

Describe your changes:

Remove errant action!

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Is this a breaking change to be called out in the release notes?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@scottbell scottbell linked an issue Jan 25, 2024 that may be closed by this pull request
7 tasks
@scottbell scottbell added this to the Target:4.0.0 milestone Jan 25, 2024
@scottbell scottbell requested review from ozyx and charlesh88 January 25, 2024 10:16
@scottbell scottbell marked this pull request as ready for review January 25, 2024 10:17
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2b2c74d) 56.00% compared to head (e5accaa) 55.99%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7414      +/-   ##
==========================================
- Coverage   56.00%   55.99%   -0.01%     
==========================================
  Files         662      662              
  Lines       26301    26301              
  Branches     2551     2551              
==========================================
- Hits        14729    14728       -1     
- Misses      10862    10863       +1     
  Partials      710      710              
Flag Coverage Δ
e2e-full 41.97% <ø> (ø)
e2e-stable 59.87% <ø> (-0.07%) ⬇️
unit 48.92% <ø> (ø)
Files Coverage Δ
...plugins/displayLayout/components/TelemetryView.vue 2.40% <ø> (ø)

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b2c74d...e5accaa. Read the comment docs.

@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Jan 25, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Jan 25, 2024
Copy link
Contributor

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice fix

@scottbell scottbell merged commit 3e5ada8 into master Jan 25, 2024
40 of 53 checks passed
@scottbell scottbell deleted the 7400-actions-menu-on-display-layout-alphanumeric-doesnt-work branch January 25, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Actions menu on Display Layout alphanumeric doesn't work
2 participants