-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move performance tests to GHA #7412
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7412 +/- ##
==========================================
- Coverage 55.98% 55.85% -0.13%
==========================================
Files 660 660
Lines 26282 26282
Branches 2550 2550
==========================================
- Hits 14713 14679 -34
- Misses 10860 10897 +37
+ Partials 709 706 -3
*This pull request uses carry forward flags. Click here to find out more. see 11 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
@@ -5,20 +5,20 @@ executors: | |||
- image: mcr.microsoft.com/playwright:v1.39.0-focal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
linter picked this up
await page.getByRole('menuitem', { name: 'Edit Properties...' }).click(); | ||
await page | ||
.locator('#imageLocation-textarea') | ||
.fill( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keep the same image
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Describe your changes:
All Submissions:
Author Checklist
type:
label? Note: this is not necessarily the same as the original issue.Reviewer Checklist