Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move performance tests to GHA #7412

Merged
merged 6 commits into from
Jan 25, 2024
Merged

move performance tests to GHA #7412

merged 6 commits into from
Jan 25, 2024

Conversation

unlikelyzero
Copy link
Contributor

@unlikelyzero unlikelyzero commented Jan 25, 2024

Describe your changes:

  • Moves performance tests to GHA to speed up commits and lower quota
  • Adds visual test for imagery for upcoming imagery change
  • Skips a test due to a flaky app

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Is this a breaking change to be called out in the release notes?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@unlikelyzero unlikelyzero added this to the Target:4.0.0 milestone Jan 25, 2024
@unlikelyzero unlikelyzero added pr:e2e:perf Trigger perf tests type:maintenance tests, chores, or project maintenance labels Jan 25, 2024
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1148644) 55.98% compared to head (c60b1ea) 55.85%.
Report is 1 commits behind head on master.

❗ Current head c60b1ea differs from pull request most recent head 43c8d4b. Consider uploading reports for the commit 43c8d4b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7412      +/-   ##
==========================================
- Coverage   55.98%   55.85%   -0.13%     
==========================================
  Files         660      660              
  Lines       26282    26282              
  Branches     2550     2550              
==========================================
- Hits        14713    14679      -34     
- Misses      10860    10897      +37     
+ Partials      709      706       -3     
Flag Coverage Δ *Carryforward flag
e2e-full 41.97% <ø> (ø) Carriedforward from 8e2243f
e2e-stable 59.78% <ø> (-0.29%) ⬇️
unit 48.80% <ø> (-0.13%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

see 11 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1148644...43c8d4b. Read the comment docs.

@github-actions github-actions bot removed the pr:e2e:perf Trigger perf tests label Jan 25, 2024
@unlikelyzero unlikelyzero requested a review from ozyx January 25, 2024 05:11
@@ -5,20 +5,20 @@ executors:
- image: mcr.microsoft.com/playwright:v1.39.0-focal
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linter picked this up

await page.getByRole('menuitem', { name: 'Edit Properties...' }).click();
await page
.locator('#imageLocation-textarea')
.fill(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep the same image

Copy link
Contributor

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@unlikelyzero unlikelyzero merged commit 450cab4 into master Jan 25, 2024
3 of 4 checks passed
@unlikelyzero unlikelyzero deleted the need4speed3 branch January 25, 2024 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants