-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add filtering by metadata #7388
Conversation
…f properties for metadata filtering.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #7388 +/- ##
=======================================
Coverage 55.90% 55.91%
=======================================
Files 662 662
Lines 26397 26432 +35
Branches 2563 2574 +11
=======================================
+ Hits 14757 14779 +22
- Misses 10928 10939 +11
- Partials 712 714 +2
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran locally with a test plan with metadata and appears to work correctly. Added a "No filters applied" message for both input areas and additional detail about how it works in the hint text visible while editing. LGTM.
Test plan:
Synth plan 2024-01-25.json
…t-metadata-filtering
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! These changes look good to me. There is a linting error for an unused import in TimelistComponent.vue
that will need to be addressed before merging.
There are some observations about the behavior of the filtering that might be worth noting that aren't necessarily bugs:
- If a user inputs an invalid string and saves, the string will be chopped off at the invalid character without informing the user (though it can be verified in the textarea after saving). If the invalid char is at the beginning like
:foobar
, then this term will not be saved at all. Otherwise if it is likefoo.bar
, onlyfoo
will be saved as a search term (which is probably okay). - The properties metadata is only traversed at the first level. So a value in this field would not be searched
properties.level1.level2
. - Adding only whitespace or a null value in the comma separated list will match all values.
foo, ,bar
orfoo,,bar
.
Closes: #7389
Describe your changes:
Added a new filtering section for metadata filters
Added new sourceMap array property
filterMetadata
to specify a list of properties for metadata filtering.Example:
All Submissions:
Author Checklist
type:
label? Note: this is not necessarily the same as the original issue.Reviewer Checklist