-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Expanded view for Time List #7378
Merged
Merged
Changes from 63 commits
Commits
Show all changes
79 commits
Select commit
Hold shift + click to select a range
7003f00
Add activity states domain object and interceptor to auto create one
shefalijoshi 92a30a3
Add activity state inspector option
shefalijoshi 4d4f83e
Only save status if we have a unique ids for activities
shefalijoshi 02edb99
Include the id in the activity properties
shefalijoshi e47bfed
Don't show activity state section in the inspector if multiple activi…
shefalijoshi 3c14025
Display activity properties when an activity row is selected in the t…
shefalijoshi 2e41753
Add compact view for timelist
shefalijoshi c6a6a18
Add inspector configuration for compact view
shefalijoshi a0ccc4e
Set colors based on time relation of activity
shefalijoshi 65a7e7e
Use activity id as key if it is available
shefalijoshi 176d344
Ensure the correct option is selected for activity states
shefalijoshi 9ff31d5
Closes #7377
charlesh88 ad07174
Closes #7377
charlesh88 02c796a
Add status label
shefalijoshi 44f4ac2
Rename to Expanded view and isExpanded as properties. Add display sty…
shefalijoshi b0a21d4
Refactor activity selection. Display activity properties
shefalijoshi 3655ba9
Closes #7377
charlesh88 3365039
Merge remote-tracking branch 'origin/timelist-compact-view' into time…
charlesh88 5cbd0fd
Closes #7377
charlesh88 dc1def5
Remove activity states plugin. Move the activity states interceptor t…
shefalijoshi b413a9b
Change activity states interceptor parameters to options
shefalijoshi bbf5454
Rename constants
shefalijoshi 6def4c2
Fix activity states test
shefalijoshi 9b85252
Merge branch 'master' of https://github.com/nasa/openmct into activit…
shefalijoshi 51e20ea
Addresses review comments making code more readable.
shefalijoshi 95d7488
Closes #7377
charlesh88 585b60d
Closes #7377
charlesh88 15acbc9
Remove ExpandedView component and pull the ExpandedViewItem up to the…
shefalijoshi dcad88c
Merge branch 'master' into timelist-compact-view
shefalijoshi e209b00
Fix sorting for compact view.
shefalijoshi 3bd09fc
Merge branch 'timelist-compact-view' of https://github.com/nasa/openm…
shefalijoshi 5908f96
Merge branch 'master' into activity-state-display
shefalijoshi 34c1f20
Closes #7377
charlesh88 e6fb968
Merge remote-tracking branch 'origin/timelist-compact-view' into time…
charlesh88 6682d00
Closes #7377
charlesh88 78f2852
Add e2e test for activity states feature.
shefalijoshi 5c6a733
Address review comments. Rename variables, documentation.
shefalijoshi 42ed592
No shallow copy
shefalijoshi 7931d4b
Merge branch 'master' of https://github.com/nasa/openmct into timelis…
shefalijoshi b5a73d3
Merge branch 'activity-state-display' of https://github.com/nasa/open…
shefalijoshi 6ac08b0
Merge updates to activity-state
shefalijoshi 8798aa1
Merge branch 'master' of https://github.com/nasa/openmct into timelis…
shefalijoshi 6ae216d
Sync with activity states PR
shefalijoshi c51f828
Draft of progress-pie
shefalijoshi 3e0342a
- Add `s-selected` styling for Expanded Time List elements.
charlesh88 21f6279
Add 2 new date formats
shefalijoshi 6116662
Look and feel enhancements for pie, zero duration events and start an…
shefalijoshi e74be9b
Fix pie show/hide condition
shefalijoshi 9ceb8a6
Merge branch 'timelist-compact-view' of github.com:nasa/openmct into …
charlesh88 9f7d931
Final touches to the pie and labels
shefalijoshi eb80bcb
Merge branch 'timelist-compact-view' of github.com:nasa/openmct into …
charlesh88 a0aa1c9
Refactor label logic
shefalijoshi d9a50b4
Merge branch 'timelist-compact-view' of github.com:nasa/openmct into …
charlesh88 884373e
Closes #7377
charlesh88 9e00836
Merge branch 'master' of https://github.com/nasa/openmct into timelis…
shefalijoshi a56931e
Remove use of ListView - no point passing arrays around since we are …
shefalijoshi bb74f21
We addded a new column for duration and changed the previous duration…
shefalijoshi 905801c
Fix expanded view for timelist tests
shefalijoshi 088b4b0
Closes #7377
charlesh88 91a2c62
Merge remote-tracking branch 'origin/timelist-compact-view' into time…
charlesh88 3ad4acf
Merge branch 'master' into timelist-compact-view
charlesh88 af161f9
Closes #7377
charlesh88 a9feb37
Optimize rendering of timelist activities
shefalijoshi 32781e2
Remove focused test
shefalijoshi e248c78
Merge branch 'timelist-compact-view' of https://github.com/nasa/openm…
shefalijoshi a09522d
Merge branch 'master' of https://github.com/nasa/openmct into timelis…
shefalijoshi 333b683
Address review comments
shefalijoshi 1bf5a15
Remove reactive selection for plan activities
shefalijoshi 004957d
destructure props into individual item properties for render performa…
shefalijoshi ac80da4
Merge remote-tracking branch 'origin' into timelist-compact-view
charlesh88 6026876
Merge branch 'timelist-compact-view' of https://github.com/nasa/openm…
shefalijoshi 73c2e7e
Use local variables and remove JSON utility methods
shefalijoshi c03d7bb
Change cancelled to skipped
shefalijoshi c45c6a2
Focus the activity tab when shown
shefalijoshi f068090
Fix label updates
shefalijoshi 14ede06
Merge branch 'master' into timelist-compact-view
shefalijoshi fbd271a
Add countup to cspell
shefalijoshi fb38cdb
Remove progress pie due to licensing unknowns
shefalijoshi 5cfa222
Merge branch 'timelist-compact-view' of https://github.com/nasa/openm…
shefalijoshi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whoa