-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 2d canvas fallback logic #7295
Conversation
Current Playwright Test Results Summary✅ 161 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 12/12/2023 11:05:10pm UTC)
|
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Log plot tests Log Plot ticks are functionally correct in regular and log mode and after refresh
Retry 1 • Initial Attempt |
0% (0)0 / 39 runsfailed over last 7 days |
28.21% (11)11 / 39 runsflaked over last 7 days |
📄 functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 2 Flakes
Top 1 Common Error Messages
|
2 Test Cases Affected |
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1 • Initial Attempt |
0% (0)0 / 39 runsfailed over last 7 days |
53.85% (21)21 / 39 runsflaked over last 7 days |
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1 • Initial Attempt |
0% (0)0 / 39 runsfailed over last 7 days |
41.03% (16)16 / 39 runsflaked over last 7 days |
📄 functional/planning/timelist.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1 • Initial Attempt |
11.29% (7)7 / 62 runsfailed over last 7 days |
64.52% (40)40 / 62 runsflaked over last 7 days |
📄 functional/plugins/notebook/notebookSnapshots.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Snapshot image tests Can drop an image onto a notebook and create a new entry
Retry 1 • Initial Attempt |
0% (0)0 / 39 runsfailed over last 7 days |
56.41% (22)22 / 39 runsflaked over last 7 days |
Current Playwright Test Results Summary
✅ 14 Passing
Run may still be in progress, this comment will be updated as current testing workflow or job completes...
(Last updated on 12/12/2023 11:05:10pm UTC)
Run Details
Running Workflow e2e-couchdb on Github Actions
Commit: 1e4ed36
Started: 12/12/2023 10:57:25pm UTC
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release/3.2.0 #7295 +/- ##
================================================
Coverage ? 55.94%
================================================
Files ? 655
Lines ? 26249
Branches ? 2527
================================================
Hits ? 14684
Misses ? 10856
Partials ? 709
Continue to review full report in Codecov by Sentry.
|
Closes #7294
Describe your changes:
This is a subset of @scottbell 's changes in #7202
It's basically just a null check to prevent the 2D fallback code from failing.
All Submissions:
Author Checklist
Reviewer Checklist