-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update API Readme to indicate renderWhenVisible
function is optional
#7285
Update API Readme to indicate renderWhenVisible
function is optional
#7285
Conversation
Current Playwright Test Results Summary✅ 15 Passing Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 12/13/2023 09:57:38am UTC) Run DetailsRunning Workflow e2e-couchdb on Github Actions Commit: e6aac77 Started: 12/13/2023 09:55:55am UTC Current Playwright Test Results Summary✅ 164 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 12/13/2023 09:57:38am UTC)
|
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Gantt Chart Replaces a plan with a new plan
Retry 1 • Initial Attempt |
0% (0)0 / 49 runsfailed over last 7 days |
2.04% (1)1 / 49 runflaked over last 7 days |
📄 functional/planning/timelist.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1 • Initial Attempt |
8.16% (4)4 / 49 runsfailed over last 7 days |
69.39% (34)34 / 49 runsflaked over last 7 days |
📄 functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1 • Initial Attempt |
0% (0)0 / 25 runsfailed over last 7 days |
60% (15)15 / 25 runsflaked over last 7 days |
📄 functional/plugins/notebook/notebookSnapshots.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Snapshot image tests Can drop an image onto a notebook and create a new entry
Retry 1 • Initial Attempt |
0% (0)0 / 25 runsfailed over last 7 days |
48% (12)12 / 25 runsflaked over last 7 days |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #7285 +/- ##
==========================================
+ Coverage 55.10% 55.90% +0.79%
==========================================
Files 655 655
Lines 26297 26297
Branches 2541 2541
==========================================
+ Hits 14492 14701 +209
+ Misses 11103 10888 -215
- Partials 702 708 +6
*This pull request uses carry forward flags. Click here to find out more. see 53 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…erwhenvisible-is-required-it-should-be-optional
Closes #7284
Describe your changes:
Updated API documentation to indicate
renderWhenVisible
function is optionalAll Submissions:
Author Checklist
Reviewer Checklist