Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#7234): Fix frame deletion in Flexible Layouts #7244

Merged
merged 5 commits into from
Nov 17, 2023

Conversation

ozyx
Copy link
Contributor

@ozyx ozyx commented Nov 17, 2023

Closes #7234

Describe your changes:

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@ozyx ozyx added this to the Target:3.2.0 milestone Nov 17, 2023
Copy link
Contributor

@unlikelyzero unlikelyzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two small additional assertions

@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Nov 17, 2023
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Merging #7244 (3b8bbb6) into master (15ee830) will decrease coverage by 14.09%.
The diff coverage is n/a.

❗ Current head 3b8bbb6 differs from pull request most recent head 5a9235f. Consider uploading reports for the commit 5a9235f to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #7244       +/-   ##
===========================================
- Coverage   55.95%   41.87%   -14.09%     
===========================================
  Files         654      417      -237     
  Lines       26224    12997    -13227     
  Branches     2526        0     -2526     
===========================================
- Hits        14673     5442     -9231     
+ Misses      10845     7555     -3290     
+ Partials      706        0      -706     
Flag Coverage Δ
e2e-full 41.87% <ø> (ø)
e2e-stable ?
unit ?
Files Coverage Δ
src/plugins/flexibleLayout/toolbarProvider.js 5.76% <ø> (-76.93%) ⬇️

... and 525 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15ee830...5a9235f. Read the comment docs.

@ozyx ozyx enabled auto-merge (squash) November 17, 2023 17:53
Copy link

deploysentinel bot commented Nov 17, 2023

Current Playwright Test Results Summary

✅ 162 Passing - ⚠️ 3 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 11/17/2023 06:02:10pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: 5a9235f

Started: 11/17/2023 05:55:15pm UTC

⚠️ Flakes

📄   functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1Initial Attempt
0% (0) 0 / 45 runs
failed over last 7 days
44.44% (20) 20 / 45 runs
flaked over last 7 days
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1Initial Attempt
0% (0) 0 / 45 runs
failed over last 7 days
60% (27) 27 / 45 runs
flaked over last 7 days

📄   functional/planning/timelist.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1Initial Attempt
1.37% (1) 1 / 73 run
failed over last 7 days
58.90% (43) 43 / 73 runs
flaked over last 7 days

View Detailed Build Results


Current Playwright Test Results Summary

✅ 14 Passing

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 11/17/2023 06:02:10pm UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: 5a9235f

Started: 11/17/2023 05:55:40pm UTC

View Detailed Build Results


@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Nov 17, 2023
@ozyx ozyx merged commit b9ae461 into master Nov 17, 2023
@ozyx ozyx deleted the mct7234-but-wait-theres-more branch November 17, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Flex Layout] Remove Frame button doesn't work anymore
2 participants