-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(#7234): Fix frame deletion in Flexible Layouts #7244
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two small additional assertions
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #7244 +/- ##
===========================================
- Coverage 55.95% 41.87% -14.09%
===========================================
Files 654 417 -237
Lines 26224 12997 -13227
Branches 2526 0 -2526
===========================================
- Hits 14673 5442 -9231
+ Misses 10845 7555 -3290
+ Partials 706 0 -706
... and 525 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Current Playwright Test Results Summary✅ 162 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 11/17/2023 06:02:10pm UTC)
|
|
2 Test Cases Affected |
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1 • Initial Attempt |
0% (0)0 / 45 runsfailed over last 7 days |
44.44% (20)20 / 45 runsflaked over last 7 days |
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1 • Initial Attempt |
0% (0)0 / 45 runsfailed over last 7 days |
60% (27)27 / 45 runsflaked over last 7 days |
📄 functional/planning/timelist.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1 • Initial Attempt |
1.37% (1)1 / 73 runfailed over last 7 days |
58.90% (43)43 / 73 runsflaked over last 7 days |
Current Playwright Test Results Summary
✅ 14 Passing
Run may still be in progress, this comment will be updated as current testing workflow or job completes...
(Last updated on 11/17/2023 06:02:10pm UTC)
Run Details
Running Workflow e2e-couchdb on Github Actions
Commit: 5a9235f
Started: 11/17/2023 05:55:40pm UTC
Closes #7234
Describe your changes:
All Submissions:
Author Checklist
Reviewer Checklist