Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine display options and add Independent Time Conductor option for Time List view #7161

Merged
merged 9 commits into from
Nov 1, 2023

Conversation

shefalijoshi
Copy link
Contributor

@shefalijoshi shefalijoshi commented Oct 23, 2023

Closes #7113

Describe your changes:

In the Time List Inspector:

  • Remove display options and durations for Past and Future events.
  • Remove durations for Current events (only Don't show and Show all available now)
  • Expose independent time conductor for timelist.

In the Time List view:

  • Color of current events changed to bring more in-line with color conventions.
  • Changed Time List rgba() colors to solids.
  • Removed bolding on current events text.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@deploysentinel
Copy link

deploysentinel bot commented Oct 23, 2023

Current Playwright Test Results Summary

✅ 14 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 11/01/2023 03:47:23pm UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: 1ac69f4

Started: 11/01/2023 03:45:04pm UTC

⚠️ Flakes

📄   functional/plugins/notebook/notebookWithCouchDB.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Notebook Tests with CouchDB @couchdb Inspect Notebook Entry Network Requests
Retry 1Initial Attempt
0% (0) 0 / 38 runs
failed over last 7 days
5.26% (2) 2 / 38 runs
flaked over last 7 days

View Detailed Build Results


Current Playwright Test Results Summary

✅ 147 Passing - ⚠️ 5 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 11/01/2023 03:47:23pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: 1ac69f4

Started: 10/31/2023 05:01:14pm UTC

⚠️ Flakes

📄   functional/plugins/conditionSet/conditionSet.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Basic Condition Set Use ConditionSet has correct outputs when telemetry is and is not available
Retry 1Initial Attempt
0% (0) 0 / 112 runs
failed over last 7 days
0.89% (1) 1 / 112 run
flaked over last 7 days

📄   functional/plugins/imagery/exampleImagery.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Example Imagery in Display Layout View Large action leaves keeps realtime mode paused
Retry 1Initial Attempt
0% (0) 0 / 91 runs
failed over last 7 days
1.10% (1) 1 / 91 run
flaked over last 7 days

📄   functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1Initial Attempt
8.24% (7) 7 / 85 runs
failed over last 7 days
34.12% (29) 29 / 85 runs
flaked over last 7 days

📄   functional/planning/timelist.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1Initial Attempt
4.92% (6) 6 / 122 runs
failed over last 7 days
50.82% (62) 62 / 122 runs
flaked over last 7 days

📄   functional/plugins/notebook/notebookSnapshots.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Snapshot image tests Can drop an image onto a notebook and create a new entry
Retry 1Initial Attempt
5.49% (5) 5 / 91 runs
failed over last 7 days
67.03% (61) 61 / 91 runs
flaked over last 7 days

View Detailed Build Results


@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #7161 (1ac69f4) into master (a0fd1f0) will decrease coverage by 0.03%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##           master    #7161      +/-   ##
==========================================
- Coverage   55.81%   55.78%   -0.03%     
==========================================
  Files         651      652       +1     
  Lines       26192    26159      -33     
  Branches     2536     2522      -14     
==========================================
- Hits        14618    14592      -26     
+ Misses      10870    10862       -8     
- Partials      704      705       +1     
Flag Coverage Δ *Carryforward flag
e2e-full 41.76% <ø> (-0.04%) ⬇️ Carriedforward from 1fba9d2
e2e-stable 57.66% <100.00%> (+0.25%) ⬆️
unit 49.32% <71.42%> (-0.08%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
src/plugins/timelist/inspector/EventProperties.vue 5.88% <ø> (-5.23%) ⬇️
...gins/timelist/inspector/TimelistPropertiesView.vue 9.09% <ø> (ø)
src/ui/components/ObjectFrame.vue 4.16% <ø> (-1.96%) ⬇️
src/ui/layout/BrowseBar.vue 47.31% <ø> (-0.57%) ⬇️
src/utils/constants.js 100.00% <100.00%> (ø)
src/plugins/timelist/TimelistComponent.vue 59.27% <69.23%> (+1.50%) ⬆️

... and 13 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0fd1f0...1ac69f4. Read the comment docs.

@charlesh88 charlesh88 self-requested a review October 24, 2023 17:42
@charlesh88 charlesh88 changed the title Refine display options and add independent time conductor option for timelist Refine display options and add Independent Time Conductor option for Time List view Oct 24, 2023
- Color of current events changed to bring more in-line with color conventions.
- Changed Time List rgba colors to solids.
- Removed bolding on current events text.
Copy link
Contributor

@charlesh88 charlesh88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ozyx ozyx added this to the Target:3.2.0 milestone Oct 24, 2023
Copy link
Contributor

@michaelrogers michaelrogers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look fantastic Shefali!

@shefalijoshi shefalijoshi added the pr:e2e:couchdb npm run test:e2e:couchdb label Nov 1, 2023
@shefalijoshi shefalijoshi enabled auto-merge (squash) November 1, 2023 15:41
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Nov 1, 2023
@shefalijoshi shefalijoshi merged commit ae22920 into master Nov 1, 2023
@shefalijoshi shefalijoshi deleted the mct-7113-fix-timelist branch November 1, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Time List view] Time List view ignores Current Events "Don't show" setting
5 participants